code review 5713044: time: skip a often-flaky test in short mode

src/pkg/time/sleep_test.go

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package time_test
 
 import (
         "errors"
         "fmt"
         "runtime"
@@ skipping 102 matching lines @@
         if testing.Short() {
                 Delta = 10 * Millisecond
         }
         t0 := Now()
         for i := 0; i < Count; i++ {
                 <-After(Delta)
         }
         t1 := Now()
         d := t1.Sub(t0)
         target := Delta * Count
-        if d < target*9/10 || d > target*30/10 {
-                t.Fatalf("%d ticks of %s took %s, expected %s", Count, Delta, d, target)
+        if d < target*9/10 {
+                t.Fatalf("%d ticks of %s too fast: took %s, expected %s", Count, Delta, d, target)
+        }
+        if !testing.Short() && d > target*30/10 {
+                t.Fatalf("%d ticks of %s too slow: took %s, expected %s", Count, Delta, d, target)
         }
 }
 
 func TestAfterStop(t *testing.T) {
         AfterFunc(100*Millisecond, func() {})
         t0 := NewTimer(50 * Millisecond)
         c1 := make(chan bool, 1)
         t1 := AfterFunc(150*Millisecond, func() { c1 <- true })
         c2 := After(200 * Millisecond)
         if !t0.Stop() {
@@ skipping 78 matching lines @@
                 go func(i int) {
                         timer := AfterFunc(2*Second, func() {
                                 t.Fatalf("timer %d was not stopped", i)
                         })
                         Sleep(1 * Second)
                         timer.Stop()
                 }(i)
         }
         Sleep(3 * Second)
 }