Issue 5711056: code review 5711056: cmd/go: fix -I flag for gc command

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5711056: code review 5711056: cmd/go: fix -I flag for gc command (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by niemeyer

Modified:
13 years, 1 month ago

Reviewers:

CC:
rsc, remyoudompheng, golang-dev

Visibility:
Public.

Patch Set 2 : code review 5711056: cmd/go: fix GOPATH support #

Patch Set 3 : diff -r 60df364bae52 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 60df364bae52 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r e440e326b540 https://go.googlecode.com/hg/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/cmd/go/build.go	View	1 2 3	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

niemeyer

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 1 month ago (2012-03-01 20:38:40 UTC) #1

remyoudompheng

http://codereview.appspot.com/5711056/diff/3001/src/cmd/go/build.go File src/cmd/go/build.go (right): http://codereview.appspot.com/5711056/diff/3001/src/cmd/go/build.go#newcode794 src/cmd/go/build.go:794: dir = filepath.Join(filepath.Dir(dir), "gccgo") can you use filepath.Join(dir, "gccgo") ...

13 years, 1 month ago (2012-03-01 20:54:54 UTC) #2

niemeyer

Hello rsc@golang.org, remyoudompheng@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 1 month ago (2012-03-01 20:56:39 UTC) #3

niemeyer

13 years, 1 month ago (2012-03-01 20:56:50 UTC) #4

remyoudompheng

LGTM, fixes build of my local packages. I don't know if rsc has something to ...

13 years, 1 month ago (2012-03-01 21:10:41 UTC) #5

niemeyer

13 years, 1 month ago (2012-03-01 23:13:12 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=a1faf94606dd ***

cmd/go: fix -I flag for gc command

R=rsc, remyoudompheng
CC=golang-dev
http://codereview.appspot.com/5711056

Expand All Messages | Collapse All Messages