code review 5711044: os: diagnose chdir error during StartProcess

os: diagnose chdir error during StartProcess

[rsc, 2012-02-29 20:48:51]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-02-29 20:50:44]

LGTM
On Feb 29, 2012 12:48 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> os: diagnose chdir error during StartProcess
>
> Please review this at
http://codereview.appspot.com/**5711044/<http://codereview.appspot.com/5711044/>
>
> Affected files:
>  M src/pkg/os/exec_posix.go
>
>
> Index: src/pkg/os/exec_posix.go
> ==============================**==============================**=======
> --- a/src/pkg/os/exec_posix.go
> +++ b/src/pkg/os/exec_posix.go
> @@ -18,6 +18,16 @@
>  //
>  // If there is an error, it will be of type *PathError.
>  func StartProcess(name string, argv []string, attr *ProcAttr) (p
> *Process, err error) {
> +       // Double-check existence of the directory we want
> +       // to chdir into.  We can make the error clearer this way.
> +       if attr != nil && attr.Dir != "" {
> +               if _, err := Stat(attr.Dir); err != nil {
> +                       pe := err.(*PathError)
> +                       pe.Op = "chdir"
> +                       return nil, pe
> +               }
> +       }
> +
>        sysattr := &syscall.ProcAttr{
>                Dir: attr.Dir,
>                Env: attr.Env,
>
>
>

[rsc, 2012-02-29 20:54:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=6ac64dcb6fad ***

os: diagnose chdir error during StartProcess

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5711044