Issue 5710046: code review 5710046: go/printer, gofmt: improved comment placement

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5710046: code review 5710046: go/printer, gofmt: improved comment placement (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by gri

Modified:
13 years, 1 month ago

Reviewers:

CC:
r, rsc, golang-dev

Visibility:
Public.

Description

go/printer, gofmt: improved comment placement Applied gofmt -w src misc (no changes). Fixes issue 3147.

Patch Set 1 #

Patch Set 2 : diff -r c8afb6fb97a0 https://code.google.com/p/go #

Patch Set 3 : diff -r c8afb6fb97a0 https://code.google.com/p/go #

Patch Set 4 : diff -r c8afb6fb97a0 https://code.google.com/p/go #

Patch Set 5 : diff -r c8afb6fb97a0 https://code.google.com/p/go #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -31 lines)			Patch
M	src/pkg/go/printer/printer.go	View	1	3 chunks	+33 lines, -31 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.golden	View	1	1 chunk	+85 lines, -0 lines	0 comments	Download
M	src/pkg/go/printer/testdata/comments.input	View	1	1 chunk	+85 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gri

Hello r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

13 years, 1 month ago (2012-03-01 00:47:38 UTC) #1

gri

13 years, 1 month ago (2012-03-01 01:25:18 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=d1db89095347 ***

go/printer, gofmt: improved comment placement

Applied gofmt -w src misc (no changes).

Fixes issue 3147.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/5710046

Expand All Messages | Collapse All Messages