Issue 5708061: code review 5708061: pkg/runtime: 2 sanity checks in the runtime-gdb.py pret...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5708061: code review 5708061: pkg/runtime: 2 sanity checks in the runtime-gdb.py pret... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by lvd

Modified:
13 years ago

Reviewers:

CC:
rsc, bsiegert, golang-dev

Visibility:
Public.

Description

pkg/runtime: 2 sanity checks in the runtime-gdb.py prettyprinters. Don't try to print obviously corrupt slices or interfaces. Doesn't actually solve 3047 or 2818, but seems a good idea anyway.

Patch Set 2 : diff -r 1c2e5d6d7660 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1c2e5d6d7660 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 1c2e5d6d7660 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 5 : diff -r 1c2e5d6d7660 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 1c2e5d6d7660 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r 1c2e5d6d7660 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r cf269312d192 https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -34 lines)			Patch
	M	src/pkg/runtime/runtime-gdb.py	View	1 2 3 4 5 6	13 chunks	+48 lines, -34 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

lvd

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2012-02-29 15:01:03 UTC) #1

bsiegert

Just a nitpick. http://codereview.appspot.com/5708061/diff/1002/src/pkg/runtime/runtime-gdb.py File src/pkg/runtime/runtime-gdb.py (right): http://codereview.appspot.com/5708061/diff/1002/src/pkg/runtime/runtime-gdb.py#newcode8 src/pkg/runtime/runtime-gdb.py:8: section in the compiled binary. The ...

13 years ago (2012-02-29 15:33:19 UTC) #2

rsc

LGTM but read the diffs yourself There are some inappropriate mid-line tabs.

13 years ago (2012-02-29 15:36:43 UTC) #3

lvd

http://codereview.appspot.com/5708061/diff/1002/src/pkg/runtime/runtime-gdb.py File src/pkg/runtime/runtime-gdb.py (right): http://codereview.appspot.com/5708061/diff/1002/src/pkg/runtime/runtime-gdb.py#newcode8 src/pkg/runtime/runtime-gdb.py:8: section in the compiled binary. The [68]l linkers emit ...

13 years ago (2012-02-29 15:37:05 UTC) #4

lvd

13 years ago (2012-02-29 15:42:31 UTC) #6

*** Submitted as http://code.google.com/p/go/source/detail?r=64a406cd2578 ***

pkg/runtime: 2 sanity checks in the runtime-gdb.py prettyprinters.

Don't try to print obviously corrupt slices or interfaces.
Doesn't actually solve 3047 or 2818, but seems a good idea anyway.

R=rsc, bsiegert
CC=golang-dev
http://codereview.appspot.com/5708061

Expand All Messages | Collapse All Messages