Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(397)

Issue 5707059: Change LT_VERSION_INFO so that SONAME is changed for ibus 1.5. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by fujiwara
Modified:
12 years ago
Reviewers:
shawn.p.huang
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Change LT_VERSION_INFO so that SONAME is changed for ibus 1.5. TEST=Linux desktop

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with message #3. #

Total comments: 1

Patch Set 3 : Updated with message #6. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M configure.ac View 1 2 3 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 6
fujiwara
Since the SONAME is calculated by lt_current - lt_age, I think lt_age = 0 is ...
12 years, 1 month ago (2012-02-29 03:50:52 UTC) #1
fujiwara
There are several build errors: # ./autogen.sh # make distcheck make[1]: Enter directory `/root/rpmbuild/BUILD/ibus-head/src' CC ...
12 years, 1 month ago (2012-02-29 09:11:50 UTC) #2
Peng
https://codereview.appspot.com/5707059/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/5707059/diff/1/configure.ac#newcode30 configure.ac:30: m4_define([ibus_interface_age], [5]) ibus_abi_current = 5 lt_current = ibus_abi_current = ...
12 years, 1 month ago (2012-02-29 16:45:25 UTC) #3
fujiwara
On 2012/02/29 16:45:25, Peng wrote: > https://codereview.appspot.com/5707059/diff/1/configure.ac > File configure.ac (right): > > https://codereview.appspot.com/5707059/diff/1/configure.ac#newcode30 > ...
12 years, 1 month ago (2012-03-01 01:48:55 UTC) #4
fujiwara
On 2012/03/01 01:48:55, fujiwara wrote: > On 2012/02/29 16:45:25, Peng wrote: > > https://codereview.appspot.com/5707059/diff/1/configure.ac > ...
12 years, 1 month ago (2012-03-01 04:23:49 UTC) #5
Peng
12 years ago (2012-03-01 14:17:57 UTC) #6
lgtm with comment

http://codereview.appspot.com/5707059/diff/4002/configure.ac
File configure.ac (right):

http://codereview.appspot.com/5707059/diff/4002/configure.ac#newcode49
configure.ac:49:
[ibus_major_version.ibus_abi_current.ibus_abi_revision.ibus_abi_age])
I guess it should be 
ibus_major_version.(ibus_abi_current-age).age.revision
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b