src/pkg/os/os_test.go - Issue 5707052: code review 5707052: os: release process handle at the end of windows (*Proc...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/os/os_test.go

Issue 5707052: code review 5707052: os: release process handle at the end of windows (*Proc... (Closed)

Patch Set: diff -r 053b4207e7dc https://go.googlecode.com/hg/ Created 13 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/os/os_test.go

===================================================================

--- a/src/pkg/os/os_test.go

+++ b/src/pkg/os/os_test.go

@@ -530,7 +530,6 @@

if err != nil {

t.Fatalf("StartProcess: %v", err)

}

- defer p.Release()

w.Close()

var b bytes.Buffer

@@ -848,7 +847,6 @@

if err != nil {

t.Fatal(err)

}

- defer p.Release()

w.Close()

var b bytes.Buffer

« no previous file with comments | « src/pkg/os/exec_windows.go ('k') | no next file » | no next file with comments »