Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2928)

Issue 5704053: Fixed build errors in ui/gtk3 with vala-0.15.1 and gtk3-3.3.14 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by fujiwara
Modified:
12 years, 1 month ago
Reviewers:
shawn.p.huang
CC:
shawn.p.huang_gmail.com
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix build errors in ui/gtk3 with vala-0.15.1 and gtk3-3.3.14 TEST=Linux desktop

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with the latest master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M ui/gtk3/candidatepanel.vala View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gtk3/handle.vala View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
fujiwara
12 years, 1 month ago (2012-02-29 05:35:20 UTC) #1
Peng
https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala File ui/gtk3/handle.vala (right): https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala#newcode157 ui/gtk3/handle.vala:157: context.render_handle(cr, Does it build for fedora 16? If not, ...
12 years, 1 month ago (2012-02-29 15:40:35 UTC) #2
fujiwara
On 2012/02/29 15:40:35, Peng wrote: > https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala > File ui/gtk3/handle.vala (right): > > https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala#newcode157 > ...
12 years, 1 month ago (2012-03-01 02:26:15 UTC) #3
fujiwara
On 2012/03/01 02:26:15, fujiwara wrote: > On 2012/02/29 15:40:35, Peng wrote: > > https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala > ...
12 years, 1 month ago (2012-03-01 02:27:52 UTC) #4
Peng
12 years, 1 month ago (2012-03-01 02:56:21 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b