https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala File ui/gtk3/handle.vala (right): https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala#newcode157 ui/gtk3/handle.vala:157: context.render_handle(cr, Does it build for fedora 16? If not, ...
13 years, 11 months ago
(2012-02-29 15:40:35 UTC)
#2
13 years, 11 months ago
(2012-03-01 02:26:15 UTC)
#3
On 2012/02/29 15:40:35, Peng wrote:
> https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala
> File ui/gtk3/handle.vala (right):
>
> https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala#newcode157
> ui/gtk3/handle.vala:157: context.render_handle(cr,
> Does it build for fedora 16? If not, could we find a way which build for both
16
> and latest?
I confirmed the warning is also happened in f16:
% valac a.vala --pkg=glib-2.0 --pkg=gtk+-3.0 --pkg=cairo
a.vala:14.13-14.29: warning: Gtk.render_handle has been deprecated since
vala-0.16. Use StyleContext.render_handle
Compilation succeeded - 1 warning(s)
On 2012/03/01 02:26:15, fujiwara wrote: > On 2012/02/29 15:40:35, Peng wrote: > > https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala > ...
13 years, 11 months ago
(2012-03-01 02:27:52 UTC)
#4
On 2012/03/01 02:26:15, fujiwara wrote:
> On 2012/02/29 15:40:35, Peng wrote:
> > https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala
> > File ui/gtk3/handle.vala (right):
> >
> > https://codereview.appspot.com/5704053/diff/1/ui/gtk3/handle.vala#newcode157
> > ui/gtk3/handle.vala:157: context.render_handle(cr,
> > Does it build for fedora 16? If not, could we find a way which build for
both
> 16
> > and latest?
>
> I confirmed the warning is also happened in f16:
>
> % valac a.vala --pkg=glib-2.0 --pkg=gtk+-3.0 --pkg=cairo
> a.vala:14.13-14.29: warning: Gtk.render_handle has been deprecated since
> vala-0.16. Use StyleContext.render_handle
> Compilation succeeded - 1 warning(s)
% rpm -q vala gtk3
vala-0.14.2-1.fc16.x86_64
gtk3-3.2.2-4.fc16.x86_64
% rpm -q vala gtk3
vala-0.15.1-3.fc17.x86_64
gtk3-3.3.14-1.fc17.x86_64
Issue 5704053: Fixed build errors in ui/gtk3 with vala-0.15.1 and gtk3-3.3.14
(Closed)
Created 13 years, 11 months ago by fujiwara
Modified 13 years, 11 months ago
Reviewers: shawn.p.huang_gmail.com
Base URL: git@github.com:ibus/ibus.git@master
Comments: 1