Simplify ibus_config_watch tests using fixtures.

Simplify ibus_config_watch tests using fixtures.


BUG=none
TEST=manual

[Daiki Ueno, 2012-02-29 08:39:37]

cf. https://codereview.appspot.com/5091045/#msg14

[Peng, 2012-02-29 15:08:34]

https://codereview.appspot.com/5702058/diff/1/src/tests/ibus-config.c
File src/tests/ibus-config.c (right):

https://codereview.appspot.com/5702058/diff/1/src/tests/ibus-config.c#newcode264
src/tests/ibus-config.c:264: change_value (IBusConfig  *config,
How about change this function to 
static void
change_and_test( config, section, name, expect_section, expect_name, data). So
it can make the loops simpler.

https://codereview.appspot.com/5702058/diff/1/src/tests/ibus-config.c#newcode358
src/tests/ibus-config.c:358: if (data->notified[i].section != NULL) {
I think the 'if' statement is not necessary.
Just need test fixture->date.section is always NULL.

[Daiki Ueno, 2012-03-01 01:21:58]

https://codereview.appspot.com/5702058/diff/1/src/tests/ibus-config.c
File src/tests/ibus-config.c (right):

https://codereview.appspot.com/5702058/diff/1/src/tests/ibus-config.c#newcode264
src/tests/ibus-config.c:264: change_value (IBusConfig  *config,
On 2012/02/29 15:08:35, Peng wrote:
> How about change this function to 
> static void
> change_and_test( config, section, name, expect_section, expect_name, data). So
> it can make the loops simpler.

Thanks, that is a good idea.  Fixed.

https://codereview.appspot.com/5702058/diff/1/src/tests/ibus-config.c#newcode358
src/tests/ibus-config.c:358: if (data->notified[i].section != NULL) {
On 2012/02/29 15:08:35, Peng wrote:
> I think the 'if' statement is not necessary.
> Just need test fixture->date.section is always NULL.

Done.

[Peng, 2012-03-01 01:24:54]

lgtm