Issue 5702057: Fix no gconf engines_order and the engine setup button on ibus-setup.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5702057: Fix no gconf engines_order and the engine setup button on ibus-setup. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by fujiwara

Modified:
12 years, 1 month ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix no gconf engines_order and the engine setup button on ibus-setup. TEST=Linux desktop

Patch Set 2 : Updated with message #3. #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -7 lines)			Patch
		data/ibus.schemas.in	View		1 chunk	+12 lines, -0 lines	0 comments	Download
		setup/main.py	View	1	3 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/5702057/diff/1/setup/main.py File setup/main.py (right): https://codereview.appspot.com/5702057/diff/1/setup/main.py#newcode257 setup/main.py:257: name = str(engine.props.name) why need this?

12 years, 1 month ago (2012-02-29 15:35:03 UTC) #2

Peng

12 years, 1 month ago (2012-03-01 01:27:23 UTC) #3

lgtm, with comments

https://codereview.appspot.com/5702057/diff/1/setup/main.py
File setup/main.py (right):

https://codereview.appspot.com/5702057/diff/1/setup/main.py#newcode257
setup/main.py:257: name = str(engine.props.name)
On 2012/02/29 15:35:03, Peng wrote:
> why need this?

please use engine.get_name(). It is more readable.

Expand All Messages | Collapse All Messages