code review 5701055: archive/zip: use smarter putUintXX functions to hide offsets

archive/zip: use smarter putUintXX functions to hide offsets

[adg, 2012-02-27 05:40:53]

Hello bradfitz (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg

[r, 2012-02-27 05:46:30]

LGTM
but brad should get the honors

[dsymonds, 2012-02-27 05:48:06]

You could make it even shorter by making a type that wraps the []byte
and make the putFoo functions methods on that type.

[bradfitz, 2012-02-27 05:49:57]

LGTM

On Mon, Feb 27, 2012 at 4:48 PM, David Symonds <dsymonds@golang.org> wrote:

> You could make it even shorter by making a type that wraps the []byte
> and make the putFoo functions methods on that type.
>

yeah, or on *thatType.

but it's good as-is too, and looks like normal append calls.

[adg, 2012-02-27 06:31:24]

Hello bradfitz@golang.org, r@golang.org, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-02-27 06:34:11]

LGTM

but this code should be generally more defensive.

http://codereview.appspot.com/5701055/diff/4004/src/pkg/archive/zip/writer.go
File src/pkg/archive/zip/writer.go (right):

http://codereview.appspot.com/5701055/diff/4004/src/pkg/archive/zip/writer.go...
src/pkg/archive/zip/writer.go:252: // We use these putUintXX functions instead
of encoding/binary's Write to avoid
update comment

[Kyle E. Lemons, 2012-02-27 06:34:57]

LGTM

Nice.  I love being able to attach methods to basics like that.

[adg, 2012-02-27 06:38:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=bf0768b1dece ***

archive/zip: use smarter putUintXX functions to hide offsets

R=bradfitz, r, dsymonds, kyle
CC=golang-dev
http://codereview.appspot.com/5701055