Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1032)

Issue 5700081: code review 5700081: cmd/goman: Adds a new command goman which generates and...

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 8 months ago by rcostu
Modified:
12 years, 8 months ago
Reviewers:
r, adg, r2, golang-dev
CC:
golang-dev, iant, rsc
Visibility:
Public.

Description

cmd/goman: Adds a new command goman which generates and installs man pages based on official command documentation in godoc. Fixes issue 101.

Patch Set 1 #

Patch Set 2 : diff -r bf0768b1dece https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bf0768b1dece https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -0 lines) Patch
A src/cmd/goman/goman.go View 1 1 chunk +306 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rcostu
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, iant@golang.org, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 8 months ago (2012-02-27 13:22:47 UTC) #1
rcostu
Ping? On Mon, Feb 27, 2012 at 14:22, <rcostu@gmail.com> wrote: > Reviewers: golang-dev_googlegroups.com, > > ...
12 years, 8 months ago (2012-03-05 20:51:45 UTC) #2
adg
Why not use text/template to do this? The command should be called 'man', not 'goman'.
12 years, 8 months ago (2012-03-05 23:03:10 UTC) #3
r
This program should just take a package and write a manual page to standard output. ...
12 years, 8 months ago (2012-03-06 23:14:26 UTC) #4
rcostu
On 2012/03/06 23:14:26, r wrote: > This program should just take a package and write ...
12 years, 8 months ago (2012-03-07 19:11:35 UTC) #5
r2
12 years, 8 months ago (2012-03-07 20:12:06 UTC) #6
On Mar 8, 2012, at 6:11 AM, rcostu@gmail.com wrote:

> On 2012/03/06 23:14:26, r wrote:
>> This program should just take a package and write a manual page to
> standard
>> output. People can script it to do the rest.
> 
> I'll change the name to man and try to use text/template.
> 
> I don't now if it should generate manual pages for packages too. If it
> is intended I could do a workaround to get packages and commands working
> to get the whole set of manual pages for the language.
> 
> I'll submit an update as soon as I have it finished.
> 
> http://codereview.appspot.com/5700081/

I misspoke. By package, I meant directory. To be able to do this for a package
is a separate question.

-rob


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b