Issue 5696071: code review 5696071: gc: fix string comparisons for new bool rules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5696071: code review 5696071: gc: fix string comparisons for new bool rules (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by ality

Modified:
13 years, 1 month ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

gc: fix string comparisons for new bool rules The two string comparison optimizations were missing the implicit cast from ideal bool. Fixes issue 3119.

Patch Set 1 #

Patch Set 2 : diff -r 0fa62412dbdd https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0fa62412dbdd https://code.google.com/p/go/ #

Patch Set 4 : diff -r 0e8f0096e631 https://code.google.com/p/go/ #

Patch Set 5 : diff -r aa7ded1d6fab https://code.google.com/p/go/ #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	src/cmd/gc/walk.c	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
	A	test/fixedbugs/bug425.go	View	1 2 3	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 1 month ago (2012-02-25 10:17:04 UTC) #1

ality

13 years, 1 month ago (2012-02-29 21:55:59 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=af2e71416a85 ***

gc: fix string comparisons for new bool rules

The two string comparison optimizations were
missing the implicit cast from ideal bool.

Fixes issue 3119.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5696071

Expand All Messages | Collapse All Messages