code review 5695068: gotour: save to HTML5 LocalStorage

gotour: save to HTML5 LocalStorage

This change adds LocalStorage to persist both the code that the
user has created and the page the user last visited.  To facilitate
the first, a [RESET] button was added in the lower corner.

Fixes issue 2.
Fixes issue 16.

[Kyle E. Lemons, 2012-02-26 21:59:26]

Hello adg@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go-tour

[adg, 2012-02-28 00:07:34]

Thanks for doing this.

It would be much better if the RESET button were adjacent to RUN. Can you do
that?

[Kyle E. Lemons, 2012-02-28 02:19:37]

PTAL

On 2012/02/28 00:07:34, adg wrote:
> Thanks for doing this.
> 
> It would be much better if the RESET button were adjacent to RUN. Can you do
> that?

Ah, yes, that would make more sense.  I made it [RESET] [RUN] since that moves
the run button the least from its original position.

[Kyle E. Lemons, 2012-02-28 02:23:50]

On 2012/02/28 02:19:37, Kyle E. Lemons wrote:
> PTAL
> 
> On 2012/02/28 00:07:34, adg wrote:
> > Thanks for doing this.
> > 
> > It would be much better if the RESET button were adjacent to RUN. Can you do
> > that?
> 
> Ah, yes, that would make more sense.  I made it [RESET] [RUN] since that moves
> the run button the least from its original position.

Eh, hold on, I messed something up when you first visit.

[adg, 2012-02-28 02:28:20]

I noticed that too, but I couldn't reproduce it in incognito.

On 28 February 2012 13:23,  <kyle@kylelemons.net> wrote:
> On 2012/02/28 02:19:37, Kyle E. Lemons wrote:
>>
>> PTAL
>
>
>> On 2012/02/28 00:07:34, adg wrote:
>> > Thanks for doing this.
>> >
>> > It would be much better if the RESET button were adjacent to RUN.
>
> Can you do
>>
>> > that?
>
>
>> Ah, yes, that would make more sense.  I made it [RESET] [RUN] since
>
> that moves
>>
>> the run button the least from its original position.
>
>
> Eh, hold on, I messed something up when you first visit.
>
> http://codereview.appspot.com/5695068/

[Kyle E. Lemons, 2012-02-28 02:36:05]

On 2012/02/28 02:23:50, Kyle E. Lemons wrote:
> On 2012/02/28 02:19:37, Kyle E. Lemons wrote:
> > PTAL
> > 
> > On 2012/02/28 00:07:34, adg wrote:
> > > Thanks for doing this.
> > > 
> > > It would be much better if the RESET button were adjacent to RUN. Can you
do
> > > that?
> > 
> > Ah, yes, that would make more sense.  I made it [RESET] [RUN] since that
moves
> > the run button the least from its original position.
> 
> Eh, hold on, I messed something up when you first visit.

Okay, fixed.  I'd forgotten a return.  Tested in Firefox, Safari, and Chrome on
my mac.

PTAL

[rsc, 2012-02-28 17:05:31]

On Mon, Feb 27, 2012 at 19:07,  <adg@golang.org> wrote:
> It would be much better if the RESET button were adjacent to RUN.

I haven't looked at the actual CL but it seems to me that it
would be best if RESET were nowhere near RUN, to prevent
accidental clicks.

[kevlar, 2012-02-28 18:05:01]

>
> On Mon, Feb 27, 2012 at 19:07,  <adg@golang.org> wrote:
> > It would be much better if the RESET button were adjacent to RUN.
>
> I haven't looked at the actual CL but it seems to me that it
> would be best if RESET were nowhere near RUN, to prevent
> accidental clicks.
>

Is putting it between PREV and NEXT sensible?  I initially put it there
because up top looked like it would reset the whole tour (which is doable,
bit I think less desired) and that seemed like an easy place to put
something slide-specific.

[rsc, 2012-02-28 18:10:12]

I would put it in some out of the way corner not near any other buttons,
so that the mouse would not be over there unless it was trying to get
to RESET.

[kevlar, 2012-02-28 18:15:06]

>
> I would put it in some out of the way corner not near any other buttons,
> so that the mouse would not be over there unless it was trying to get
> to RESET.
>

Lower right corner of the code box, then?

[Kyle E. Lemons, 2012-03-03 18:14:30]

PTAL.

I have moved RESET to the lower right corner.  Surprisingly, this actually works
nowadays in Chrome, Firefox, and Safari (on my mac, at least).  I can't say if
any of this works on IE or not; I don't have one handy.

On 2012/02/28 18:15:06, kevlar wrote:
> >
> > I would put it in some out of the way corner not near any other buttons,
> > so that the mouse would not be over there unless it was trying to get
> > to RESET.
> >
> 
> Lower right corner of the code box, then?

[kevlar, 2012-03-15 18:39:26]

ping

[Kyle E. Lemons, 2012-04-23 20:27:34]

Ping

Sync'd and merged.

[kevlar, 2012-05-01 17:19:20]

ping (would there be a better time to put this CL forward?)

[rsc, 2012-05-01 17:22:55]

On Tue, May 1, 2012 at 13:19,  <kevlar@google.com> wrote:
> ping (would there be a better time to put this CL forward?)

adg has been offline/traveling, and we're all a bit behind on mail.
we'll get to it.  sorry for the delay.

[adg, 2012-05-01 22:13:43]

It's on my list, it's just below a few other important things. Thanks
for your patience.

[adg, 2012-05-02 22:54:37]

LGTM

[adg, 2012-05-02 22:55:14]

*** Submitted as http://code.google.com/p/go-tour/source/detail?r=e057b1ee4434
***

      gotour: save to HTML5 LocalStorage

This change adds LocalStorage to persist both the code that the
user has created and the page the user last visited.  To facilitate
the first, a [RESET] button was added in the lower corner.

Fixes issue 2.
Fixes issue 16.

R=adg, rsc, kevlar
CC=golang-dev
http://codereview.appspot.com/5695068

Committer: Andrew Gerrand <adg@golang.org>

[adg, 2012-05-02 22:59:15]

Nice work. It's now deployed.
Thanks.

[remyoudompheng, 2013-07-20 20:14:14]

R=close