Issue 5694094: Add page notifications to ReturnThunkFactory delegate interface.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5694094: Add page notifications to ReturnThunkFactory delegate interface. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Siggi

Modified:
13 years, 1 month ago

Reviewers:
chrisha, Jói

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add page notifications to ReturnThunkFactory delegate interface. An initial step towards making return address location resolution thread-agnostic. R=chrisha@chromium.org,joi@chromium.org Committed: https://code.google.com/p/sawbuck/source/browse/#svn/trunk671

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -3 lines)			Patch
M	syzygy/agent/profiler/profiler.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	syzygy/agent/profiler/return_thunk_factory.h	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	syzygy/agent/profiler/return_thunk_factory.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	syzygy/agent/profiler/return_thunk_factory_unittests.cc	View	5 chunks	+31 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Siggi

Thanks, committing. On Mon, Feb 27, 2012 at 14:16, <chrisha@chromium.org> wrote: > lgtm > > ...

13 years, 1 month ago (2012-02-27 19:18:08 UTC) #3

LGTM

Expand All Messages | Collapse All Messages