Issue 5694082: code review 5694082: go/printer: fix test for new import path restrictions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5694082: code review 5694082: go/printer: fix test for new import path restrictions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by ality

Modified:
13 years ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

go/printer: fix test for new import path restrictions Import paths with spaces are now invalid. The builders would've caught this if they were running the long tests. I've removed the check for short tests in this package since the current tests are fast enough already.

Patch Set 1 #

Patch Set 2 : diff -r 767b6229d4dc https://code.google.com/p/go/ #

Patch Set 3 : diff -r 767b6229d4dc https://code.google.com/p/go/ #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
M	src/pkg/go/printer/printer_test.go	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	src/pkg/go/printer/testdata/declarations.golden	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/pkg/go/printer/testdata/declarations.input	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years ago (2012-02-26 03:07:05 UTC) #1

gri

13 years ago (2012-02-27 18:01:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=f3f83fcdabfb ***

go/printer: fix test for new import path restrictions

Import paths with spaces are now invalid.

The builders would've caught this if they were running
the long tests.  I've removed the check for short tests
in this package since the current tests are fast enough
already.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5694082

Committer: Robert Griesemer <gri@golang.org>

Expand All Messages | Collapse All Messages