Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(543)

Issue 569390043: Accept GUILE 2 without extra configure options (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by hanwenn
Modified:
4 years ago
Reviewers:
dak, lemzwerg, hahnjo
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Accept GUILE 2 without extra configure options A run of the regression tests at "5f4cf7bd38 - Parse inline scheme using per-expression port" shows the following issues compared to GUILE 1.8 * changed interleaving of error and progress messages. * floating point rounding differences. * an encoding error in song-basic-nonenglish.ly As of a19aed1 "GUILE2: Scale GC heap with the number of smobs", performance for large scores with GUILE 2.2 is similar to GUILE 1.8. For small scores, a 1.5 sec extra delay (due to byte-code compilation of .scm files) remains, but this does not warrant the "highly experimental" monniker.

Patch Set 1 #

Patch Set 2 : guile-config after guile-config2.2 #

Total comments: 2

Patch Set 3 : pkg-config #

Patch Set 4 : stats #

Total comments: 10

Patch Set 5 : jonas' comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -132 lines) Patch
M aclocal.m4 View 1 2 3 4 2 chunks +20 lines, -110 lines 0 comments Download
M config.make.in View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M configure.ac View 1 2 3 chunks +6 lines, -19 lines 0 comments Download

Messages

Total messages: 28
hanwenn
guile-config after guile-config2.2
4 years, 1 month ago (2020-02-21 15:26:52 UTC) #1
dak
https://codereview.appspot.com/569390043/diff/551480043/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/569390043/diff/551480043/aclocal.m4#newcode760 aclocal.m4:760: guile2.2-config guile-2.2-config guile-config-2.2 guile-config2.2 \ I think that at ...
4 years, 1 month ago (2020-02-21 15:43:38 UTC) #2
hahnjo
guile-config since 2.0 has the following comment: "This script has been deprecated. Just use pkg-config." ...
4 years, 1 month ago (2020-02-21 16:02:14 UTC) #3
lemzwerg
> Mabye it makes sense to completely turn to pkg-config? Sounds sensible. In particular, it ...
4 years, 1 month ago (2020-02-21 16:22:52 UTC) #4
dak
On 2020/02/21 16:02:14, hahnjo wrote: > guile-config since 2.0 has the following comment: > "This ...
4 years, 1 month ago (2020-02-21 16:25:02 UTC) #5
hahnjo
On 2020/02/21 16:22:52, lemzwerg wrote: > > Mabye it makes sense to completely turn to ...
4 years, 1 month ago (2020-02-21 16:34:35 UTC) #6
hanwenn
pkg-config
4 years, 1 month ago (2020-02-21 16:35:31 UTC) #7
hanwenn
On 2020/02/21 16:02:14, hahnjo wrote: > guile-config since 2.0 has the following comment: > "This ...
4 years, 1 month ago (2020-02-21 16:36:57 UTC) #8
hanwenn
On 2020/02/21 16:36:57, hanwenn wrote: > On 2020/02/21 16:02:14, hahnjo wrote: > > guile-config since ...
4 years, 1 month ago (2020-02-21 16:37:24 UTC) #9
hahnjo
On 2020/02/21 16:36:57, hanwenn wrote: > On 2020/02/21 16:02:14, hahnjo wrote: > > guile-config since ...
4 years, 1 month ago (2020-02-21 16:39:20 UTC) #10
hanwenn
On 2020/02/21 15:43:38, dak wrote: > https://codereview.appspot.com/569390043/diff/551480043/aclocal.m4 > File aclocal.m4 (right): > > https://codereview.appspot.com/569390043/diff/551480043/aclocal.m4#newcode760 > ...
4 years, 1 month ago (2020-02-21 16:42:21 UTC) #11
lemzwerg
LGTM. However, the use of the pkgconfig environment variable(s) should be documented.
4 years, 1 month ago (2020-02-21 16:53:36 UTC) #12
hanwenn
make baseline: 1.8: real 3m41.714s user 6m52.414s sys 0m36.662s 2.2: real 6m8.344s user 12m51.799s sys ...
4 years, 1 month ago (2020-02-21 17:03:07 UTC) #13
hanwenn
stats
4 years, 1 month ago (2020-02-21 17:08:04 UTC) #14
hanwenn
On 2020/02/21 16:39:20, hahnjo wrote: > On 2020/02/21 16:36:57, hanwenn wrote: > > On 2020/02/21 ...
4 years, 1 month ago (2020-02-21 17:08:34 UTC) #15
dak
On 2020/02/21 17:03:07, hanwenn wrote: > make baseline: > > 1.8: > real 3m41.714s > ...
4 years, 1 month ago (2020-02-21 17:13:57 UTC) #16
hanwenn
On Fri, Feb 21, 2020 at 6:13 PM <dak@gnu.org> wrote: > > 1.8: > > ...
4 years, 1 month ago (2020-02-21 17:24:48 UTC) #17
hahnjo
On 2020/02/21 17:08:34, hanwenn wrote: > On 2020/02/21 16:39:20, hahnjo wrote: > > $ pkg-config ...
4 years, 1 month ago (2020-02-21 17:31:40 UTC) #18
hahnjo
A few nits on m4 escapes, but otherwise LGTM - works very well on my ...
4 years, 1 month ago (2020-02-21 17:42:01 UTC) #19
hahnjo
https://codereview.appspot.com/569390043/diff/571710044/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/569390043/diff/571710044/aclocal.m4#newcode697 aclocal.m4:697: if [[ -z "$GUILE_FLAVOR" ]] ; then You can ...
4 years, 1 month ago (2020-02-21 17:48:54 UTC) #20
hanwenn
On 2020/02/21 17:31:40, hahnjo wrote: > On 2020/02/21 17:08:34, hanwenn wrote: > > On 2020/02/21 ...
4 years, 1 month ago (2020-02-21 19:12:13 UTC) #21
hanwenn
https://codereview.appspot.com/569390043/diff/571710044/aclocal.m4 File aclocal.m4 (right): https://codereview.appspot.com/569390043/diff/571710044/aclocal.m4#newcode693 aclocal.m4:693: if [[ -n "$GUILE_FLAVOR" ]] ; then On 2020/02/21 ...
4 years, 1 month ago (2020-02-21 19:15:00 UTC) #22
hanwenn
jonas' comments
4 years, 1 month ago (2020-02-21 19:15:59 UTC) #23
hanwenn
commit 670e9f7b9660822f31144cbf07788bfc28de94cd Author: Han-Wen Nienhuys <hanwen@lilypond.org> Date: Fri Feb 21 16:14:48 2020 +0100 Accept GUILE ...
4 years ago (2020-03-06 20:11:58 UTC) #24
dak
On 2020/02/21 16:34:35, hahnjo wrote: > On 2020/02/21 16:22:52, lemzwerg wrote: > > > Mabye ...
4 years ago (2020-03-07 01:20:00 UTC) #25
hanwenn
On Sat, Mar 7, 2020 at 2:20 AM <dak@gnu.org> wrote: > getting there. And as ...
4 years ago (2020-03-07 10:46:00 UTC) #26
dak
Han-Wen Nienhuys <hanwenn@gmail.com> writes: > On Sat, Mar 7, 2020 at 2:20 AM <dak@gnu.org> wrote: ...
4 years ago (2020-03-07 11:41:54 UTC) #27
hanwenn
4 years ago (2020-03-07 16:13:39 UTC) #28
On Sat, Mar 7, 2020 at 12:41 PM David Kastrup <dak@gnu.org> wrote:
>
> Han-Wen Nienhuys <hanwenn@gmail.com> writes:
>
> > On Sat, Mar 7, 2020 at 2:20 AM <dak@gnu.org> wrote:
> >
> >> getting there.  And as long as Guile-2.2 crashes frequently with
> >> segfaults when used within LilyPond,
> >
> > Can you file a bug report for any remaining Guile 2.2 crashes? I am
> > not aware of any.
>
> Just recently two segfaults in Patchy.  Since I don't get more than
> "signal 11" in the log files, there is nothing worth filing.  And since
> they occur intermittently and not reproducibly within the large runs of
> make doc, they will be related to garbage collection and thus even core
> dumps will be of comparatively little utility.  Since running Patchy on

If you can capture a core dump and a back trace, that can at least give us

> Guile-2.2 takes a performance hit of about 40% (that's where my recent
> prolonged doc run times were from)

I would also be interested in more information about this. At what
commit are you seeing a 40% performance hit? AFAICT, it should be
roughly equivalent to guile 1.8 since

 commit e36b7c7ea986418bcfebfba6c6c971db05b77afb
 Author: Han-Wen Nienhuys <hanwen@lilypond.org>
 Date:   Tue Feb 25 21:39:10 2020 +0100

    GUILE2: Do not run GC after processing every file.

> and ends up unreliable as well as not
> representative for 1.8, still our main target, I am not too enthused
> about running Patchy frequently on Guile-2.x with core dumps enabled
> (set ulimit -c 1000000 or so).
>
> How often do you run make doc?

I've been running a fair number of times recently when I was trying to
look into the speed of the build, but I've been mainly waiting for
https://codereview.appspot.com/575750043/ to hit master, so I can
build the docs in Docker too.

Let me try to repro some more.

-- 
Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b