Issue 5690068: Use nested template expansions to implement Config8888 conversions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5690068: Use nested template expansions to implement Config8888 conversions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by bsalomon

Modified:
12 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Use nested template expansions to implement Config8888 conversions. Committed: https://code.google.com/p/skia/source/detail?r=3230

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+283 lines, -240 lines)			Patch
M	gyp/core.gyp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkConfig8888.h	View	1 2 3	3 chunks	+24 lines, -231 lines	0 comments	Download
A	src/core/SkConfig8888.cpp	View	1 2 3	1 chunk	+257 lines, -0 lines	0 comments	Download
M	src/core/SkDevice.cpp	View	1 2 3	1 chunk	+1 line, -9 lines	0 comments	Download

Total messages: 2

bsalomon

I need a more general Config8888 -> Config8888 copy function as a fallback for the ...

12 years, 4 months ago (2012-02-22 20:30:59 UTC) #1

Committed off verbal LGTM