Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34)

Issue 5690064: Add ibus_unset_log_handler to release the handler in ibus_set_log_handler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by fujiwara
Modified:
2 years, 2 months ago
Reviewers:
shawn.p.huang
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
http://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Add ibus_unset_log_handler to remove the handler in ibus_set_log_handler


TEST=Linux desktop

Patch Set 1 #

Total comments: 1

Patch Set 2 : Updated with message #2. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M src/ibusshare.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/ibusshare.c View 2 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 2
fujiwara
2 years, 2 months ago #1
Peng
2 years, 2 months ago #2
lgtm with one comment

https://codereview.appspot.com/5690064/diff/1/src/ibusshare.h
File src/ibusshare.h (right):

https://codereview.appspot.com/5690064/diff/1/src/ibusshare.h#newcode340
src/ibusshare.h:340: * Releases GLIB's log handler which is used in
ibus_set_log_handler.
How about: Remove the log handler which set by ibus_set_handler()?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5