Issue 5690059: code review 5690059: net/textproto: accept bad MIME headers as browsers do

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5690059: code review 5690059: net/textproto: accept bad MIME headers as browsers do (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by bradfitz

Modified:
12 years, 8 months ago

Reviewers:

CC:
golang-dev, gri

Visibility:
Public.

Description

net/textproto: accept bad MIME headers as browsers do Accept certain non-compliant response headers (in particular, when spaces preceed the colon). All major browser and curl seem to support this, and at least one webserver seems to send these. *shrug*

Patch Set 1 #

Patch Set 2 : diff -r d83ad2b46bee https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d83ad2b46bee https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r eb269c0c7624 https://go.googlecode.com/hg/ #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -2 lines)			Patch
	M	src/pkg/net/textproto/reader.go	View	1	2 chunks	+11 lines, -2 lines	0 comments	Download
	M	src/pkg/net/textproto/reader_test.go	View	1 2 3	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 8 months ago (2012-02-21 22:55:55 UTC) #1

gri

LGTM http://codereview.appspot.com/5690059/diff/4001/src/pkg/net/textproto/reader_test.go File src/pkg/net/textproto/reader_test.go (right): http://codereview.appspot.com/5690059/diff/4001/src/pkg/net/textproto/reader_test.go#newcode167 src/pkg/net/textproto/reader_test.go:167: // tests that we read slightly-bogus MIME headers ...

12 years, 8 months ago (2012-02-21 23:44:24 UTC) #2

bradfitz

12 years, 8 months ago (2012-02-22 00:14:06 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=07183c0cc059 ***

net/textproto: accept bad MIME headers as browsers do

Accept certain non-compliant response headers
(in particular, when spaces preceed the colon).
All major browser and curl seem to support this,
and at least one webserver seems to send these.

*shrug*

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5690059

Expand All Messages | Collapse All Messages