doc: add The Laws of Reflection article
Originally published on The Go Programming Language Blog, September 6, 2011.
http://blog.golang.org/2011/09/laws-of-reflection.html
Update issue 2547
Hello golang-dev@googlegroups.com (cc: adg@golang.org, golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 1 month ago
(2012-02-21 01:30:26 UTC)
#1
http://codereview.appspot.com/5689054/diff/7001/doc/articles/laws_of_reflection.html File doc/articles/laws_of_reflection.html (right): http://codereview.appspot.com/5689054/diff/7001/doc/articles/laws_of_reflection.html#newcode105 doc/articles/laws_of_reflection.html:105: value at all, since any value has zero or ...
13 years, 1 month ago
(2012-02-22 07:00:47 UTC)
#5
It probably is an error in codereview.py that it sometimes
asks you to abandon changes that have already been submitted
(and if you don't they just remain there in `hg ps`).
On Tue, Mar 6, 2012 at 4:44 PM, <proppy@google.com> wrote:
> On 2012/03/06 12:41:12, proppy wrote:
>
>> *** Abandoned ***
>>
>
> Not abandoned, but rather already submitted by adg@.
>
>
>
http://codereview.appspot.com/**5689054/<http://codereview.appspot.com/5689054/>
>
On Tue, Mar 6, 2012 at 08:11, Maxim Pimenov <mpimenov@google.com> wrote:
> It probably is an error in codereview.py that it sometimes
> asks you to abandon changes that have already been submitted
> (and if you don't they just remain there in `hg ps`).
When you run hg sync, it looks to see if your CL has been
closed, but it only looks through the last N changes, for
some N that I don't remember. If you are not syncing often
(adg submitted this 6 days ago) then N can be too small.
So be it.
Russ
Thanks for the explanation.
For the record, N=100 and can be varied in
codereview.py:/^def sync_changes(ui, repo)
On Tue, Mar 6, 2012 at 6:28 PM, Russ Cox <rsc@golang.org> wrote:
> On Tue, Mar 6, 2012 at 08:11, Maxim Pimenov <mpimenov@google.com> wrote:
> > It probably is an error in codereview.py that it sometimes
> > asks you to abandon changes that have already been submitted
> > (and if you don't they just remain there in `hg ps`).
>
> When you run hg sync, it looks to see if your CL has been
> closed, but it only looks through the last N changes, for
> some N that I don't remember. If you are not syncing often
> (adg submitted this 6 days ago) then N can be too small.
> So be it.
>
> Russ
>
Issue 5689054: code review 5689054: doc: add The Laws of Reflection article
(Closed)
Created 13 years, 1 month ago by proppy
Modified 13 years ago
Reviewers: mpimenov, rsc
Base URL:
Comments: 27
