code review 5688046: os: drop the Wait function and the options to Process.Wait

os: drop the Wait function and the options to Process.Wait
They are portability problems and the options are almost always zero in practice anyway.

[r, 2012-02-20 04:02:50]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-02-20 04:08:58]

LGTM

[r2, 2012-02-20 04:20:47]

to make the Wait story more consistent, i've also deleted the Wait function. you
must use the method.
PTAL

-rob

[dsymonds, 2012-02-20 04:24:26]

LGTM

http://codereview.appspot.com/5688046/diff/26/doc/go1.html
File doc/go1.html (right):

http://codereview.appspot.com/5688046/diff/26/doc/go1.html#newcode1468
doc/go1.html:1468: Also, the function <code>Wait</code> is gone, only the method
of
replace the second comma with a semicolon?

[bradfitz, 2012-02-20 04:26:13]

LGTM

http://codereview.appspot.com/5688046/diff/26/doc/go1.tmpl
File doc/go1.tmpl (right):

http://codereview.appspot.com/5688046/diff/26/doc/go1.tmpl#newcode1368
doc/go1.tmpl:1368: The <a href="/pkg/os/#Wait"><code>Wait</code></a> function
has
s/function/method/ ?

http://codereview.appspot.com/5688046/diff/26/src/cmd/fix/oswait.go
File src/cmd/fix/oswait.go (right):

http://codereview.appspot.com/5688046/diff/26/src/cmd/fix/oswait.go#newcode49
src/cmd/fix/oswait.go:49: return
output a warning? I thought gofix could do that.

[r, 2012-02-20 04:31:01]

Hello golang-dev@googlegroups.com, dsymonds@golang.org, r@google.com,
bradfitz@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2012-02-20 04:36:13]

*** Submitted as 2a74f9121ce0 ***

os: drop the Wait function and the options to Process.Wait
They are portability problems and the options are almost always zero in practice
anyway.

R=golang-dev, dsymonds, r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5688046