Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1251)

Issue 5687083: Enable quickRejectY in SkCanvas to be inlined (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by DerekS
Modified:
12 years, 4 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Enable quickRejectY in SkCanvas to be inlined. This CL was tested against the picturePlayback bench and showed an approx 10-13% improvement on Android when playing back text. Committed: https://code.google.com/p/skia/source/detail?r=3259

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -25 lines) Patch
M include/core/SkCanvas.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 2
DerekS
12 years, 4 months ago (2012-02-22 20:52:45 UTC) #1
reed1
12 years, 4 months ago (2012-02-22 21:12:02 UTC) #2
lets break into a couple of stages:

1. test the rewrite/simplification
1.5 create a bench to time tall pictures drawn through small clips
2. make quickRejectY inline (and show the bench got faster)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b