code review 5687076: runtime: goroutine profile, stack dumps

runtime: goroutine profile, stack dumps

[rsc, 2012-02-22 06:59:52]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-02-22 21:38:31]

LGTM but please change the name of write

http://codereview.appspot.com/5687076/diff/3001/src/pkg/runtime/print.c
File src/pkg/runtime/print.c (right):

http://codereview.appspot.com/5687076/diff/3001/src/pkg/runtime/print.c#newco...
src/pkg/runtime/print.c:15: write(void *v, int32 n)
this name will confuse people editing other files.
maybe
debug_write? crash_write? trace_write?

[rsc, 2012-02-22 21:56:18]

On 2012/02/22 21:38:31, r wrote:
> LGTM but please change the name of write

it's static.  print?

[r2, 2012-02-22 23:44:12]

On 23/02/2012, at 8:56 AM, rsc@golang.org wrote:

> On 2012/02/22 21:38:31, r wrote:
>> LGTM but please change the name of write
> 
> it's static.  print?

not sure that's better. maybe just Write

[rsc, 2012-02-23 02:34:37]

changed to gwrite

[rsc, 2012-02-23 02:45:04]

*** Submitted as http://code.google.com/p/go/source/detail?r=4e38cad33649 ***

runtime: goroutine profile, stack dumps

R=golang-dev, r, r
CC=golang-dev
http://codereview.appspot.com/5687076