Issue 5681: Enables Firebug Logging in templates

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5681: Enables Firebug Logging in templates

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 7 months ago by levik

Modified:
11 years, 4 months ago

Reviewers:
shindig-dev, Evan Gilbert, davidbyttow

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

The os.log() function will now use Firebug console if available. Creates an alias to this as the global log() function for use by internal JSTemplate error handling.

Patch Set 1 #

Created: 17 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -2 lines)			Patch
		features/opensocial-templates/base.js	View		1 chunk	+16 lines, -2 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Evan Gilbert

17 years, 7 months ago (2008-09-18 20:49:54 UTC) #3

http://codereview.appspot.com/5681/diff/1/2
File features/opensocial-templates/base.js (right):

http://codereview.appspot.com/5681/diff/1/2#newcode60
Line 60: log = os.log;
I'm not clear what "log" variable this is referring to.

http://codereview.appspot.com/5681/diff/1/2#newcode62
Line 62: window['log'] = os.log;
It seems a little dangerous to be overriding variables in the global scope. Is
window['log'] required for JsTemplates logging? And is there a longer version
that might be less likely to conflict with user-defined variables?

Expand All Messages | Collapse All Messages