Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(62)

Issue 5677069: Refactor 'precajole' targets (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by ihab.awad
Modified:
14 years, 4 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Refactor 'precajole' targets to sequester testing "light" precajole map from production "heavy" map. This avoids problems with previous setup wherein the "light" contents were being written out to the production "precajole.jar" output.

Patch Set 1 #

Patch Set 2 : Refactor 'precajole' targets #

Patch Set 3 : Refactor 'precajole' targets #

Total comments: 4

Patch Set 4 : Refactor 'precajole' targets #

Patch Set 5 : Refactor 'precajole' targets #

Total comments: 1

Patch Set 6 : Refactor 'precajole' targets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M . View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M build.xml View 1 2 3 4 8 chunks +21 lines, -15 lines 0 comments Download
M third_party/precajole/heavy.xml View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11
ihab.awad
14 years, 4 months ago (2012-02-16 21:51:07 UTC) #1
ihab.awad
14 years, 4 months ago (2012-02-16 21:52:18 UTC) #2
ihab.awad
14 years, 4 months ago (2012-02-16 22:42:43 UTC) #3
felix8a
lgtm++ http://codereview.appspot.com/5677069/diff/3002/build.xml File build.xml (right): http://codereview.appspot.com/5677069/diff/3002/build.xml#newcode506 build.xml:506: <target name="pluginc" depends="PluginCompiler,tools,precajole-light" this messes up some of ...
14 years, 4 months ago (2012-02-16 23:33:58 UTC) #4
ihab.awad
http://codereview.appspot.com/5677069/diff/3002/build.xml File build.xml (right): http://codereview.appspot.com/5677069/diff/3002/build.xml#newcode506 build.xml:506: <target name="pluginc" depends="PluginCompiler,tools,precajole-light" On 2012/02/16 23:33:58, felix8a wrote: > ...
14 years, 4 months ago (2012-02-17 19:24:34 UTC) #5
ihab.awad
14 years, 4 months ago (2012-02-23 01:05:33 UTC) #6
ihab.awad
14 years, 4 months ago (2012-02-23 02:44:19 UTC) #7
felix8a
lgtm http://codereview.appspot.com/5677069/diff/10001/tests/com/google/caja/plugin/GeneralBrowserTest.java File tests/com/google/caja/plugin/GeneralBrowserTest.java (right): http://codereview.appspot.com/5677069/diff/10001/tests/com/google/caja/plugin/GeneralBrowserTest.java#newcode30 tests/com/google/caja/plugin/GeneralBrowserTest.java:30: /* commented out for testing?
14 years, 4 months ago (2012-02-23 11:01:44 UTC) #8
ihab.awad
On Thu, Feb 23, 2012 at 3:01 AM, <felix8a@gmail.com> wrote: > commented out for testing? ...
14 years, 4 months ago (2012-02-23 16:25:31 UTC) #9
ihab.awad
14 years, 4 months ago (2012-02-23 18:12:02 UTC) #10
ihab.awad
14 years, 4 months ago (2012-02-23 18:33:40 UTC) #11
@4785
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b