code review 5677063: exp/winfsnotify: remove reference to _test

exp/winfsnotify: remove reference to _test
Updates issue 2573.

[r, 2012-02-16 04:19:33]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[dsymonds, 2012-02-16 04:24:43]

Does it need to watch a test-specific subdir of tmpdir? Won't just
watching tmpdir run into trouble if there are other tests executing
concurrently?


Dave.

[r, 2012-02-16 04:27:19]

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-02-16 04:28:36]

LGTM

http://codereview.appspot.com/5677063/diff/4/src/pkg/exp/winfsnotify/winfsnot...
File src/pkg/exp/winfsnotify/winfsnotify_test.go (right):

http://codereview.appspot.com/5677063/diff/4/src/pkg/exp/winfsnotify/winfsnot...
src/pkg/exp/winfsnotify/winfsnotify_test.go:118: dir, err := ioutil.TempDir("",
"inotify")
perhaps s/inotify/win&/ to be specific about it.

[r2, 2012-02-16 04:34:05]

On Feb 16, 2012, at 3:28 PM, dsymonds@golang.org wrote:

> LGTM
> 
> 
>
http://codereview.appspot.com/5677063/diff/4/src/pkg/exp/winfsnotify/winfsnot...
> File src/pkg/exp/winfsnotify/winfsnotify_test.go (right):
> 
>
http://codereview.appspot.com/5677063/diff/4/src/pkg/exp/winfsnotify/winfsnot...
> src/pkg/exp/winfsnotify/winfsnotify_test.go:118: dir, err :=
> ioutil.TempDir("", "inotify")
> perhaps s/inotify/win&/ to be specific about it.

sure, in case someone is running os x on this hardware while we're running.

-rob

[r, 2012-02-16 04:34:32]

*** Submitted as 87cc9108a3b9 ***

exp/winfsnotify: remove reference to _test
Updates issue 2573.

R=golang-dev, dsymonds, r
CC=golang-dev
http://codereview.appspot.com/5677063