Issue 5677055: Lazily allocate our global pool for imagerefs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5677055: Lazily allocate our global pool for imagerefs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by reed1

Modified:
12 years, 7 months ago

Reviewers:
digit, DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Lazily allocate our global pool for imagerefs Committed: https://code.google.com/p/skia/source/detail?r=3211

Patch Set 2 : #

Total comments: 1

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -12 lines)			Patch
	M	src/images/SkImageRef_GlobalPool.cpp	View	1	4 chunks	+30 lines, -12 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

reed1

possible companion CL for http://codereview.appspot.com/5617052/

12 years, 7 months ago (2012-02-15 21:58:09 UTC) #1

digit

https://codereview.appspot.com/5677055/diff/1/src/images/SkImageRef_GlobalPool.cpp File src/images/SkImageRef_GlobalPool.cpp (right): https://codereview.appspot.com/5677055/diff/1/src/images/SkImageRef_GlobalPool.cpp#newcode49 src/images/SkImageRef_GlobalPool.cpp:49: GetGlobalPool()->justAddedPixels(this); Is this also by design inside the mutex-lock? ...

12 years, 7 months ago (2012-02-16 15:38:46 UTC) #2

reed1

good point, new version adds a comment making that assumption clear.

12 years, 7 months ago (2012-02-16 18:23:53 UTC) #3

DerekS

On 2012/02/16 18:23:53, reed1 wrote: > good point, new version adds a comment making that ...

12 years, 7 months ago (2012-02-16 19:53:31 UTC) #4

digit

12 years, 7 months ago (2012-02-16 20:02:54 UTC) #5

LGTM

https://codereview.appspot.com/5677055/diff/4001/src/images/SkImageRef_Global...
File src/images/SkImageRef_GlobalPool.cpp (right):

https://codereview.appspot.com/5677055/diff/4001/src/images/SkImageRef_Global...
src/images/SkImageRef_GlobalPool.cpp:46: */
nice

Expand All Messages | Collapse All Messages