Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6323)

Issue 56760046: Move build process into Makefile.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by bac
Modified:
10 years, 2 months ago
Reviewers:
mp+204729, Marco Ceppi
Visibility:
Public.

Description

Move build process into Makefile. The build processes depended on several scripts. That logic was moved into the Makefile. It now handles python2 and python3 with no repetition. Also added a test to get the coverage up to 100%. This actually required removing the code that returned None in the Charm constructor (_fetch) when data was missing. Instead it now defers to the existing logic in the _parse method to raise a CharmNotFound exception. https://code.launchpad.net/~bac/charmworldlib/makefile-changes/+merge/204729 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Move build process into Makefile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -69 lines) Patch
M .bzrignore View 1 chunk +4 lines, -5 lines 0 comments Download
A HACKING.md View 1 chunk +5 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +42 lines, -23 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
D bin/configure View 1 chunk +0 lines, -12 lines 0 comments Download
D bin/lint View 1 chunk +0 lines, -8 lines 0 comments Download
D bin/test View 1 chunk +0 lines, -15 lines 0 comments Download
M charmworldlib/api.py View 1 chunk +0 lines, -1 line 0 comments Download
M charmworldlib/charm.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/test_charm.py View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 3
bac
Please take a look.
10 years, 2 months ago (2014-02-04 16:29:33 UTC) #1
bac
Please take a look.
10 years, 2 months ago (2014-02-04 16:32:52 UTC) #2
Marco Ceppi
10 years, 2 months ago (2014-02-04 22:15:48 UTC) #3
LGTM, thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b