Don't use strlen inside of loop

Don't use strlen inside of loop

This could hurt performance quite a bit.

BUG=296
TEST=

Committed: https://code.google.com/p/angleproject/source/detail?r=993

[dgkoch, 2012-02-18 05:41:04]

There's one of those in Program.cpp as well.

[dgkoch, 2012-02-21 14:34:19]

I would have hoped the compiler was smart enough to hoist the strlen out of the
loop condition so that this wouldn't truly be n^2.  In any case, the memcpy will
be much more efficient than a character by character copy. 

LGTM, but would prefer if you also fix the one in Program.cpp as well.

[zmo, 2012-02-21 18:18:12]

LGTM

[nfullagar, 2012-02-21 23:23:00]

On 2012/02/21 18:18:12, zmo wrote:
> LGTM

ping?  Also, can BUG= in description point to
http://code.google.com/p/angleproject/issues/detail?id=296

[John Bauman, 2012-02-21 23:43:36]

On 2012/02/21 14:34:19, dgkoch wrote:
> I would have hoped the compiler was smart enough to hoist the strlen out of
the
> loop condition so that this wouldn't truly be n^2.  In any case, the memcpy
will
> be much more efficient than a character by character copy. 
> 
I think possible aliasing prevents that.

> LGTM, but would prefer if you also fix the one in Program.cpp as well.

Ok, will do.