Issue 5675077: Revert r3036. This change breaks loading images as

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5675077: Revert r3036. This change breaks loading images as (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by caryclark1

Modified:
12 years, 6 months ago

Reviewers:
epoger, bsalomon, TomH

CC:
skia-review_googlegroups.com, Sami Kyöstilä

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Revert r3036. This change breaks loading images as described in Chromium issue 114107. The Chromium break may be fixed by WebKit patch 78239, at which time this patch can be reapplied. Committed: https://code.google.com/p/skia/source/detail?r=3219

Patch Set 1 #

Patch Set 2 : #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	src/core/SkBitmap.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	tests/BitmapCopyTest.cpp	View	1	2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

epoger

12 years, 6 months ago (2012-02-17 14:41:07 UTC) #4

On 2012/02/17 14:40:09, TomH wrote:
> WebKit patch 78239 was a year ago?

https://bugs.webkit.org/show_bug.cgi?id=78239 , not webkit revision #78239

Expand All Messages | Collapse All Messages