Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94)

Issue 5675061: Fix regression where we disable fonts with no specified name (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by DerekS
Modified:
12 years, 7 months ago
Reviewers:
bungeman, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix regression where we disable fonts with no specified name Committed: https://code.google.com/p/skia/source/detail?r=3202

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -44 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 2 chunks +15 lines, -12 lines 0 comments Download
M src/ports/SkFontHost_android.cpp View 3 chunks +6 lines, -9 lines 0 comments Download
M src/ports/SkFontHost_linux.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M src/ports/SkFontHost_simple.cpp View 3 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 6
DerekS
12 years, 7 months ago (2012-02-15 18:53:31 UTC) #1
DerekS
12 years, 7 months ago (2012-02-15 19:33:15 UTC) #2
reed1
LGTM do we need to update SkFontHost_fontconfig.cpp in chrome?
12 years, 7 months ago (2012-02-15 20:41:34 UTC) #3
DerekS
On 2012/02/15 20:41:34, reed1 wrote: > LGTM > > do we need to update SkFontHost_fontconfig.cpp ...
12 years, 7 months ago (2012-02-15 20:53:15 UTC) #4
reed1
We'll need to grep their version, to see if they call that "private" function from ...
12 years, 7 months ago (2012-02-15 20:54:59 UTC) #5
DerekS
12 years, 7 months ago (2012-02-15 21:02:46 UTC) #6
On 2012/02/15 20:54:59, reed1 wrote:
> We'll need to grep their version, to see if they call that "private" function
> from SkFontHost_FreeType, now that you're changing its signature.

I searched for find_name_and_attributes using the chromium code search and the
only references were these files so I think we are good to go.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b