On 2012/02/15 20:41:34, reed1 wrote: > LGTM > > do we need to update SkFontHost_fontconfig.cpp ...
12 years, 10 months ago
(2012-02-15 20:53:15 UTC)
#4
On 2012/02/15 20:41:34, reed1 wrote:
> LGTM
>
> do we need to update SkFontHost_fontconfig.cpp in chrome?
I don't know. I don't have an up-to-date copy of Chrome on my machine. What is
the best way to see if this will be a problem for them?
On 2012/02/15 20:54:59, reed1 wrote: > We'll need to grep their version, to see if ...
12 years, 10 months ago
(2012-02-15 21:02:46 UTC)
#6
On 2012/02/15 20:54:59, reed1 wrote:
> We'll need to grep their version, to see if they call that "private" function
> from SkFontHost_FreeType, now that you're changing its signature.
I searched for find_name_and_attributes using the chromium code search and the
only references were these files so I think we are good to go.
Issue 5675061: Fix regression where we disable fonts with no specified name
(Closed)
Created 12 years, 10 months ago by DerekS
Modified 12 years, 10 months ago
Reviewers: reed1, bungeman
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0