code review 5674065: net/url: regularise receiver names.

net/url: regularise receiver names.

Update issue 2946.

[dsymonds, 2012-02-16 03:21:21]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-02-16 03:27:56]

Base was named/kept on purpose to match the doc comment.
 On Feb 16, 2012 2:21 PM, <dsymonds@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net/url: regularise receiver names.
>
> Update issue 2946.
>
> Please review this at
http://codereview.appspot.com/**5674065/<http://codereview.appspot.com/5674065/>
>
> Affected files:
>  M src/pkg/net/url/url.go
>
>
> Index: src/pkg/net/url/url.go
> ==============================**==============================**=======
> --- a/src/pkg/net/url/url.go
> +++ b/src/pkg/net/url/url.go
> @@ -592,12 +592,12 @@
>  // Parse parses a URL in the context of a base URL.  The URL in ref
>  // may be relative or absolute.  Parse returns nil, err on parse
>  // failure, otherwise its return value is the same as ResolveReference.
> -func (base *URL) Parse(ref string) (*URL, error) {
> +func (u *URL) Parse(ref string) (*URL, error) {
>        refurl, err := Parse(ref)
>        if err != nil {
>                return nil, err
>        }
> -       return base.ResolveReference(refurl), nil
> +       return u.ResolveReference(refurl), nil
>  }
>
>  // ResolveReference resolves a URI reference to an absolute URI from
> @@ -606,13 +606,13 @@
>  // URL instance, even if the returned URL is identical to either the
>  // base or reference. If ref is an absolute URL, then ResolveReference
>  // ignores base and returns a copy of ref.
> -func (base *URL) ResolveReference(ref *URL) *URL {
> +func (u *URL) ResolveReference(ref *URL) *URL {
>        if ref.IsAbs() {
>                url := *ref
>                return &url
>        }
>        // relativeURI = ( net_path | abs_path | rel_path ) [ "?" query ]
> -       url := *base
> +       url := *u
>        url.RawQuery = ref.RawQuery
>        url.Fragment = ref.Fragment
>        if ref.Opaque != "" {
> @@ -632,7 +632,7 @@
>                url.Path = ref.Path
>        } else {
>                // The "rel_path" case.
> -               path := resolvePath(base.Path, ref.Path)
> +               path := resolvePath(u.Path, ref.Path)
>                if !strings.HasPrefix(path, "/") {
>                        path = "/" + path
>                }
>
>
>

[dsymonds, 2012-02-16 03:46:40]

On Thu, Feb 16, 2012 at 2:27 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> Base was named/kept on purpose to match the doc comment.

It's inconsistently applied, though. Parse and ResolveReference also
effectively operate on a base URL. Are there other Go packages that
rename the receiver in this way?

[dsymonds, 2012-02-16 03:51:02]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitzgoog, 2012-02-16 03:55:12]

http://codereview.appspot.com/5674065/diff/2005/src/pkg/net/url/url.go
File src/pkg/net/url/url.go (right):

http://codereview.appspot.com/5674065/diff/2005/src/pkg/net/url/url.go#newcod...
src/pkg/net/url/url.go:592: // Parse parses a URL in the context of the URL. 
The provided URL in ref
Maybe:

Parse parses a URL reference in the context of the receiver URL. The URL
reference may be relative or absolute.

?

[dsymonds, 2012-02-16 03:56:34]

Hello golang-dev@googlegroups.com, bradfitz@golang.org, bradfitz@google.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitzgoog, 2012-02-16 03:59:42]

LGTM

[dsymonds, 2012-02-16 04:08:00]

*** Submitted as http://code.google.com/p/go/source/detail?r=1a03fdfef2ab ***

net/url: regularise receiver names.

Update issue 2946.

R=golang-dev, bradfitz, bradfitz
CC=golang-dev
http://codereview.appspot.com/5674065