Issue 5674059: Lazily allocate gNameList, and protect its usage behind the global mutex

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5674059: Lazily allocate gNameList, and protect its usage behind the global mutex (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by reed1

Modified:
13 years ago

Reviewers:
digit, DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Lazily allocate gNameList, and protect its usage behind the global mutex

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -20 lines)			Patch
	M	src/ports/SkFontHost_android.cpp	View		11 chunks	+45 lines, -20 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

Derek is going to take this patch, and test it on device before committing

13 years ago (2012-02-16 13:15:31 UTC) #3

DerekS

13 years ago (2012-02-16 15:07:53 UTC) #4

Fixed a deadlock situation and finishing up testing now.  I'll commit and
have mike close out the review shortly.

~ Derek

On Thu, Feb 16, 2012 at 8:15 AM, <reed@google.com> wrote:

> Derek is going to take this patch, and test it on device before
> committing
>
>
https://codereview.appspot.**com/5674059/<https://codereview.appspot.com/5674...
>

Expand All Messages | Collapse All Messages