Allow libjpeg_turbo to configure (using gyp) on FreeBSD.

Allow libjpeg_turbo to configure (using gyp) on FreeBSD.

Allow both the built-in and system yasm on FreeBSD, and add (prefix_dir)/include to the include path.

Obtained from:	George Liaskos <geo.liaskos@gmail.com>

BUG=
TBR=cpu@chromium.org

[r.c.ladan, 2014-02-01 09:18:17]

Patch updated as suggested by phajdan.jr

Initially the patch was created using my rene@freebsd.org address, while I only
signed the CLA with my r.c.ladan@gmail.com address

Let me know if it would be best to:
- sign the CLA with my freebsd.org address to (and add that to AUTHORS)
- re-submit this issue with my gmail.com address

[r.c.ladan, 2014-02-10 22:07:42]

On 2014/02/01 09:18:17, r.c.ladan wrote:
> Patch updated as suggested by phajdan.jr
> 
> Initially the patch was created using my mailto:rene@freebsd.org address,
while I only
> signed the CLA with my mailto:r.c.ladan@gmail.com address
> 
> Let me know if it would be best to:
> - sign the CLA with my http://freebsd.org address to (and add that to AUTHORS)
> - re-submit this issue with my http://gmail.com address

Any news on this ticket?

[r.c.ladan, 2014-03-14 12:45:38]

I rewrote the commits on my local branch so that my authors name is
r.c.ladan@gmail.com

[phajdan.jr, 2014-03-14 21:33:57]

LGTM

[r.c.ladan, 2014-03-15 09:15:08]

Since I'm not a committer, I added some more people from third_party/OWNERS and
joi@ who landed a patch for tools/grit/ for me earlier.

[raphael.kubo.da.costa, 2014-03-15 14:06:52]

Committed https://src.chromium.org/viewvc/chrome?revision=257324&view=revision,
but I don't have karma to close this issue or change its description.

[raphael.kubo.da.costa, 2014-03-15 14:08:30]

On 2014/03/15 14:06:52, raphael.kubo.da.costa wrote:
> Committed
https://src.chromium.org/viewvc/chrome?revision=257324&view=revision,
> but I don't have karma to close this issue or change its description.

Oh, and sorry that the commit message did not mention you, Rene. I had changed
it locally but gcl apparently used the description in the CL.

[noel chromium, 2014-03-17 21:47:21]

I'm just gonna assume that the FreeBSD you're configuration for
have our libjpeg_turbo fixes [1].

[1] http://seclists.org/fulldisclosure/2013/Nov/83

[r.c.ladan, 2014-03-18 21:41:35]

On 2014/03/17 21:47:21, noel chromium wrote:
> I'm just gonna assume that the FreeBSD you're configuration for
> have our libjpeg_turbo fixes [1].
> 
> [1] http://seclists.org/fulldisclosure/2013/Nov/83

Thanks for the pointer.
Currently FreeBSD uses the jpeg library shipped with Chromium itself.

[noel chromium, 2014-03-18 23:17:20]

Ok good, Chromium third_party/libjpeg is patched/fixed also.

[rmcilroy, 2014-03-27 12:48:35]

On 2014/03/18 23:17:20, noel chromium wrote:
> Ok good, Chromium third_party/libjpeg is patched/fixed also.

This CL is blocking a roll of libjpeg_turbo to Chromium
(https://codereview.chromium.org/212113004/).  The gyp stage fails with
"Undefined variable prefix_dir".  Where is the prefix_dir variable meant to be
set (it doesn't seem to be set anywhere in Chromium gyp files). Could you land a
fix or revert please (I can revert if there isn't an easy fix)?

[r.c.ladan, 2014-03-27 13:08:19]

On 2014/03/27 12:48:35, rmcilroy wrote:
> On 2014/03/18 23:17:20, noel chromium wrote:
> > Ok good, Chromium third_party/libjpeg is patched/fixed also.
> 
> This CL is blocking a roll of libjpeg_turbo to Chromium
> (https://codereview.chromium.org/212113004/).  The gyp stage fails with
> "Undefined variable prefix_dir".  Where is the prefix_dir variable meant to be
> set (it doesn't seem to be set anywhere in Chromium gyp files). Could you land
a
> fix or revert please (I can revert if there isn't an easy fix)?

Yes, appearantly nobody noticed that this would be a problem until the
accompanying DEPS update (https://codereview.chromium.org/201883002/) made the
Chromium (try/build)bots unhappy.  prefix_dir is used in the FreeBSD port
(package source) system to pass the current value of PREFIX, which indicates the
path where *this* port (here Chromium) will be installed.  I think it is best to
remove these three lines from the gyp file and modify the FreeBSD port, I'll do
that when I'm back at FreeBSD again:

 275           'include_dirs': [
 276             '<(prefix_dir)/include',
 277           ],

[raphael.kubo.da.costa, 2014-03-27 13:12:03]

<rmcilroy@chromium.org> writes:

> On 2014/03/18 23:17:20, noel chromium wrote:
>> Ok good, Chromium third_party/libjpeg is patched/fixed also.
>
> This CL is blocking a roll of libjpeg_turbo to Chromium
> (https://codereview.chromium.org/212113004/).  The gyp stage fails with
> "Undefined variable prefix_dir".  Where is the prefix_dir variable meant
> to be set (it doesn't seem to be set anywhere in Chromium gyp files).
> Could you land a fix or revert please (I can revert if there isn't an
> easy fix)?

Sorry, the prefix_dir part looks like a downstream FreeBSD packaging
detail that ended up creeping into the patch here.

https://codereview.chromium.org/214413007/ should fix it.

[rmcilroy, 2014-03-27 13:34:48]

On 2014/03/27 13:12:03, raphael.kubo.da.costa wrote:
> <mailto:rmcilroy@chromium.org> writes:
> 
> > On 2014/03/18 23:17:20, noel chromium wrote:
> >> Ok good, Chromium third_party/libjpeg is patched/fixed also.
> >
> > This CL is blocking a roll of libjpeg_turbo to Chromium
> > (https://codereview.chromium.org/212113004/).  The gyp stage fails with
> > "Undefined variable prefix_dir".  Where is the prefix_dir variable meant
> > to be set (it doesn't seem to be set anywhere in Chromium gyp files).
> > Could you land a fix or revert please (I can revert if there isn't an
> > easy fix)?
> 
> Sorry, the prefix_dir part looks like a downstream FreeBSD packaging
> detail that ended up creeping into the patch here.
> 
> https://codereview.chromium.org/214413007/ should fix it.

Thanks for the quick fix Raphael.