Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(360)

Issue 5672083: Allows arbitrary attributes in static HTML. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by metaweta
Modified:
14 years, 4 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This change gets rid of the _d_attributes map and uses the data-caja-* attribute namespace instead. TemplateCompiler now renames attributes rather than stripping them out, and the *Attribute() methods in Domado prefix attributes if they're not otherwise whitelisted.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Allows arbitrary attributes in static HTML. #

Patch Set 3 : Allows arbitrary attributes in static HTML. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -34 lines) Patch
M src/com/google/caja/lang/html/HtmlSchema.java View 1 chunk +3 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/domado.js View 1 2 8 chunks +20 lines, -19 lines 0 comments Download
M src/com/google/caja/plugin/templates/TemplateCompiler.java View 3 chunks +13 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/templates/TemplateSanitizer.java View 1 1 chunk +11 lines, -5 lines 0 comments Download
M tests/com/google/caja/plugin/templates/TemplateSanitizerTest.java View 3 chunks +6 lines, -6 lines 1 comment Download
M tests/com/google/caja/service/HtmlHandlerTest.java View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5
metaweta
14 years, 4 months ago (2012-02-18 01:02:20 UTC) #1
Jasvir
http://codereview.appspot.com/5672083/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): http://codereview.appspot.com/5672083/diff/1/src/com/google/caja/plugin/domado.js#newcode3093 src/com/google/caja/plugin/domado.js:3093: TameElement.prototype.getAttribute = nodeMethod(function (attribName) { Do you need to ...
14 years, 4 months ago (2012-02-20 20:07:37 UTC) #2
metaweta
On 2012/02/20 20:07:37, Jasvir wrote: > http://codereview.appspot.com/5672083/diff/1/src/com/google/caja/plugin/domado.js > File src/com/google/caja/plugin/domado.js (right): > > http://codereview.appspot.com/5672083/diff/1/src/com/google/caja/plugin/domado.js#newcode3093 > ...
14 years, 4 months ago (2012-02-21 17:36:51 UTC) #3
Jasvir
LGTM++ http://codereview.appspot.com/5672083/diff/9001/tests/com/google/caja/plugin/templates/TemplateSanitizerTest.java File tests/com/google/caja/plugin/templates/TemplateSanitizerTest.java (right): http://codereview.appspot.com/5672083/diff/9001/tests/com/google/caja/plugin/templates/TemplateSanitizerTest.java#newcode62 tests/com/google/caja/plugin/templates/TemplateSanitizerTest.java:62: "WARNING: removing attribute data-caja-unknown " + Consider emitting ...
14 years, 4 months ago (2012-02-21 23:56:03 UTC) #4
metaweta
14 years, 4 months ago (2012-02-22 18:21:13 UTC) #5
On 2012/02/21 23:56:03, Jasvir wrote:
> LGTM++
> 
>
http://codereview.appspot.com/5672083/diff/9001/tests/com/google/caja/plugin/...
> File tests/com/google/caja/plugin/templates/TemplateSanitizerTest.java
(right):
> 
>
http://codereview.appspot.com/5672083/diff/9001/tests/com/google/caja/plugin/...
> tests/com/google/caja/plugin/templates/TemplateSanitizerTest.java:62:
"WARNING:
> removing attribute data-caja-unknown " +
> Consider emitting the correct attribute name in the error message.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b