aaclip needs to handle paths with holes

aaclip needs to handle paths with holes
Committed: https://code.google.com/p/skia/source/detail?r=3209

[guanqun, 2012-02-29 08:07:23]

Hi Mike,

Bisecting the commits, I found starting from revision 3209 and 3210, SampleApp
will segment fault when I'm pressing right arrow key on GM:aaclip, here's the
backtrace, (though running gm directly won't get segfault).

Using host libthread_db library "/lib64/libthread_db.so.1".
../src/core/SkAAClip.cpp:1014: failed assertion "prevY < row->fY"

Program received signal SIGSEGV, Segmentation fault.
0x000000000047f8d1 in SkAAClip::Builder::finish (this=0x7fffffffd0b0,
target=0x7fffffffd260) at ../src/core/SkAAClip.cpp:1014
1014	            SkASSERT(prevY < row->fY);  // must be monotonic
(gdb) bt
#0  0x000000000047f8d1 in SkAAClip::Builder::finish (this=0x7fffffffd0b0,
target=0x7fffffffd260)
    at ../src/core/SkAAClip.cpp:1014
#1  0x000000000047c0b9 in SkAAClip::setPath (this=0x7fffffffd260, path=...,
clip=0x7fffffffd130, doAA=true)
    at ../src/core/SkAAClip.cpp:1317
#2  0x000000000047b5fe in SkAAClip::setRect (this=0x7fffffffd260, r=...,
doAA=true) at ../src/core/SkAAClip.cpp:682
#3  0x000000000047d0b6 in SkAAClip::op (this=0xe451c8, rOrig=...,
op=SkRegion::kIntersect_Op, doAA=true)
    at ../src/core/SkAAClip.cpp:1716
#4  0x00000000004dea00 in SkRasterClip::op (this=0xe451b0, r=...,
op=SkRegion::kIntersect_Op, doAA=true)
    at ../src/core/SkRasterClip.cpp:170
#5  0x000000000049a27a in SkCanvas::clipRect (this=0x7fffffffdb50, rect=...,
op=SkRegion::kIntersect_Op, doAA=true)
    at ../src/core/SkCanvas.cpp:1015
#6  0x0000000000454d9e in skiagm::draw (canvas=0x7fffffffdb50, target=..., x=30,
y=10) at ../gm/aaclip.cpp:35
#7  0x0000000000454f52 in skiagm::draw_column (canvas=0x7fffffffdb50, x=30,
y=10) at ../gm/aaclip.cpp:48
#8  0x0000000000454fed in skiagm::draw_rect_tests (canvas=0x7fffffffdb50) at
../gm/aaclip.cpp:58
#9  0x00000000004551c5 in skiagm::AAClipGM::onDraw (this=0x933820,
canvas=0x7fffffffdb50) at ../gm/aaclip.cpp:95
#10 0x0000000000405424 in skiagm::GM::drawContent (this=0x933820,
canvas=0x7fffffffdb50) at ../gm/gm.cpp:22
#11 0x0000000000416086 in GMSampleView::onDrawContent (this=0x933850,
canvas=0x7fffffffdb50)
    at ../samplecode/GMSampleView.h:40
#12 0x0000000000414652 in SampleView::onDraw (this=0x933850,
canvas=0x7fffffffdb50) at ../samplecode/SampleApp.cpp:2022
#13 0x0000000000549f1c in SkView::draw (this=0x933850, canvas=0x7fffffffdb50) at
../src/views/SkView.cpp:127
#14 0x00000000004145a5 in SampleView::draw (this=0x933850,
canvas=0x7fffffffdb50) at ../samplecode/SampleApp.cpp:2012
#15 0x0000000000549fba in SkView::draw (this=0xbb81a0, canvas=0x7fffffffdb50) at
../src/views/SkView.cpp:140
#16 0x00000000004145a5 in SampleView::draw (this=0xbb81a0,
canvas=0x7fffffffdb50) at ../samplecode/SampleApp.cpp:2012
#17 0x0000000000549fba in SkView::draw (this=0x912290, canvas=0x7fffffffdb50) at
../src/views/SkView.cpp:140
#18 0x00000000004103e1 in SampleWindow::draw (this=0x912290,
canvas=0x7fffffffdb50) at ../samplecode/SampleApp.cpp:865
#19 0x000000000054c96e in SkWindow::update (this=0x912290, updateArea=0x0,
canvas=0x7fffffffdb50)
    at ../src/views/SkWindow.cpp:208
#20 0x00000000005559cc in SkOSWindow::onEvent (this=0x912290, evt=...) at
../src/utils/unix/SkOSWindow_Unix.cpp:232
#21 0x0000000000412baf in SampleWindow::onEvent (this=0x912290, evt=...) at
../samplecode/SampleApp.cpp:1427
#22 0x0000000000544dba in SkEventSink::doEvent (this=0x912290, evt=...) at
../src/views/SkEventSink.cpp:75
#23 0x000000000054540b in SkEventSink::DoEvent (evt=...) at
../src/views/SkEventSink.cpp:230
#24 0x000000000054476d in SkEvent::ProcessEvent () at
../src/views/SkEvent.cpp:426
#25 0x00000000005555a1 in SkOSWindow::loop (this=0x912290) at
../src/utils/unix/SkOSWindow_Unix.cpp:145
#26 0x000000000054dadb in main (argc=1, argv=0x7fffffffe048) at
../unix_test_app/main.cpp:37

[reed1, 2012-02-29 13:59:34]

great catch, thanks!

fixed in 3281