Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(585)

Issue 567090043: Issue 5661: Fix some conversion warnings in Source_file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by Dan Eble
Modified:
2 months, 2 weeks ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

https://sourceforge.net/p/testlilyissues/issues/5661/ Use ssize_t for line and column numbers in Input and Source_file. size_t might be more appropriate, but I want to focus on fixing warnings and not on checking unsigned arithmetic.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -42 lines) Patch
M lily/include/input.hh View 1 chunk +5 lines, -5 lines 0 comments Download
M lily/include/source-file.hh View 2 chunks +7 lines, -10 lines 0 comments Download
M lily/input.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M lily/input-scheme.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M lily/parse-scm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/source-file.cc View 7 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 1
lemzwerg
2 months, 3 weeks ago (2020-01-13 17:57:16 UTC) #1
LGTM, thanks!  And I think that `ssize_t` is a good type in general since it
allows to use the value -1 as a special flag.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b