Issue 5664047: [Chromium] [WebSocket] provide a path to bind WebFrameClient and SocketStreamHandle

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5664047: [Chromium] [WebSocket] provide a path to bind WebFrameClient and SocketStreamHandle (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Takashi Toyoshima

Modified:
13 years, 4 months ago

Reviewers:

Base URL:
http://svn.webkit.org/repository/webkit/trunk

Visibility:
Public.

More Reviews

Description

[Chromium] [WebSocket] provide a path to bind WebFrameClient and SocketStreamHandle The whole change. (not for review) BUG= TEST=

Patch Set 1 #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -79 lines)			Patch
M	Source/WebCore/loader/FrameLoader.h	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	Source/WebCore/loader/FrameLoader.cpp	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	Source/WebCore/loader/FrameLoaderClient.h	View	3 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/WebCore/platform/network/SocketStreamHandleClient.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/WebCore/platform/network/chromium/SocketStreamHandle.h	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	Source/WebCore/websockets/ThreadableWebSocketChannel.cpp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/WebCore/websockets/WebSocketChannel.h	View	6 chunks	+6 lines, -5 lines	0 comments	Download
M	Source/WebCore/websockets/WebSocketChannel.cpp	View	14 chunks	+32 lines, -30 lines	0 comments	Download
M	Source/WebCore/websockets/WorkerThreadableWebSocketChannel.cpp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/WebKit/chromium/public/WebFrameClient.h	View	4 chunks	+8 lines, -2 lines	0 comments	Download
M	Source/WebKit/chromium/public/platform/WebSocketStreamHandle.h	View	1 chunk	+9 lines, -3 lines	0 comments	Download
M	Source/WebKit/chromium/src/FrameLoaderClientImpl.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp	View	4 chunks	+8 lines, -1 line	0 comments	Download
M	Source/WebKit/chromium/src/SocketStreamHandle.cpp	View	4 chunks	+5 lines, -30 lines	0 comments	Download
A	Source/WebKit/chromium/src/SocketStreamHandleInternal.h	View	1 chunk	+91 lines, -0 lines	0 comments	Download