code review 5663047: net: disable multicast test on Alpha GNU/Linux

net: disable multicast test on Alpha GNU/Linux

Alpha GNU/Linux does not have /proc/net/igmp[6].

[iant, 2012-02-14 00:22:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-02-14 00:23:12]

LGTM

whoa

[bradfitz, 2012-02-14 00:27:00]

I thought /proc was in the kernel. Is it Linux that doesn't have it on
alpha, or the GNU userspace? :) *ducks*

On Tue, Feb 14, 2012 at 11:22 AM, <iant@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: disable multicast test on Alpha GNU/Linux
>
> Alpha GNU/Linux does not have /proc/net/igmp[6].
>
> Please review this at
http://codereview.appspot.com/**5663047/<http://codereview.appspot.com/5663047/>
>
> Affected files:
>  M src/pkg/net/multicast_test.go
>
>
> Index: src/pkg/net/multicast_test.go
> ==============================**==============================**=======
> --- a/src/pkg/net/multicast_test.**go
> +++ b/src/pkg/net/multicast_test.**go
> @@ -33,7 +33,7 @@
>        case "netbsd", "openbsd", "plan9", "windows":
>                return
>        case "linux":
> -               if runtime.GOARCH == "arm" {
> +               if runtime.GOARCH == "arm" || runtime.GOARCH == "alpha" {
>                        return
>                }
>        }
>
>
>

[iant, 2012-02-14 05:31:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=af58e40639cf ***

net: disable multicast test on Alpha GNU/Linux

Alpha GNU/Linux does not have /proc/net/igmp[6].

R=golang-dev, rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/5663047

[iant2, 2012-02-14 05:32:17]

Brad Fitzpatrick <bradfitz@golang.org> writes:

> I thought /proc was in the kernel. Is it Linux that doesn't have it on
> alpha, or the GNU userspace? :) *ducks*

If you had received as many e-mail messages from RMS on the subject as I
have, you also would instinctively type GNU/Linux in essentially all
cases.

Ian

>
> On Tue, Feb 14, 2012 at 11:22 AM, <iant@golang.org> wrote:
>
>> Reviewers: golang-dev_googlegroups.com,
>>
>> Message:
>> Hello golang-dev@googlegroups.com,
>>
>> I'd like you to review this change to
>> https://go.googlecode.com/hg/
>>
>>
>> Description:
>> net: disable multicast test on Alpha GNU/Linux
>>
>> Alpha GNU/Linux does not have /proc/net/igmp[6].
>>
>> Please review this at
http://codereview.appspot.com/**5663047/<http://codereview.appspot.com/5663047/>
>>
>> Affected files:
>>  M src/pkg/net/multicast_test.go
>>
>>
>> Index: src/pkg/net/multicast_test.go
>> ==============================**==============================**=======
>> --- a/src/pkg/net/multicast_test.**go
>> +++ b/src/pkg/net/multicast_test.**go
>> @@ -33,7 +33,7 @@
>>        case "netbsd", "openbsd", "plan9", "windows":
>>                return
>>        case "linux":
>> -               if runtime.GOARCH == "arm" {
>> +               if runtime.GOARCH == "arm" || runtime.GOARCH == "alpha" {
>>                        return
>>                }
>>        }
>>
>>
>>