Issue 5661043: Set LCD font smoothing to "medium" for gm on Mac, regardless of system settings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5661043: Set LCD font smoothing to "medium" for gm on Mac, regardless of system settings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by epoger

Modified:
12 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Set LCD font smoothing to "medium" for gm on Mac, regardless of system settings http://code.google.com/p/skia/issues/detail?id=382 ('make gm results consistent regardless of system LCDtext settings') Committed: https://code.google.com/p/skia/source/detail?r=3184

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -2 lines)			Patch
M	gm/gmmain.cpp	View	2 chunks	+3 lines, -0 lines	0 comments	Download
A	gm/system_preferences.h	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	gm/system_preferences_default.cpp	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	gm/system_preferences_mac.mm	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	gyp/gm.gyp	View	2 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

epoger

On 2012/02/13 20:07:23, epoger wrote: got verbal LG from Mike

12 years, 4 months ago (2012-02-14 14:50:01 UTC) #2

epoger

12 years, 4 months ago (2012-02-14 14:50:56 UTC) #3

On 2012/02/14 14:50:01, epoger wrote:
> On 2012/02/13 20:07:23, epoger wrote:
> 
> got verbal LG from Mike

From conversation with Mike: this is something we will probably want to move out
into a more common directory sometime soon, because it will be generally useful.

Expand All Messages | Collapse All Messages