Issue 565920043: midi: convert data to bigendian encoding directly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 565920043: midi: convert data to bigendian encoding directly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years ago by hanwenn

Modified:
4 years ago

Reviewers:
Dan Eble, Carl, carl.d.sorensen, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

midi: convert data to bigendian encoding directly Before, the MIDI code would encode data as a hex string, to convert it binary afterwards. Shortcut this process. Silence some cast warnings

Patch Set 1 #

Patch Set 2 : commit msg #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -40 lines)			Patch
M	flower/include/string-convert.hh	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	flower/string-convert.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	lily/midi-chunk.cc	View	3 chunks	+8 lines, -20 lines	0 comments	Download
M	lily/midi-item.cc	View	4 chunks	+19 lines, -20 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Dan Eble

You're not doing this for performance, just for simplicity, correct?

4 years ago (2020-04-17 17:11:59 UTC) #4

hanwenn

On 2020/04/17 17:11:59, Dan Eble wrote: > You're not doing this for performance, just for ...

4 years ago (2020-04-17 17:25:55 UTC) #5

hanwenn

4 years ago (2020-05-02 22:22:33 UTC) #6

commit f51b4dbe635670cc08789daa0d9670f60fa47423
Author: Han-Wen Nienhuys <hanwen@lilypond.org>
Date:   Fri Apr 17 14:23:58 2020 +0200

    midi: convert data to bigendian encoding directly

Expand All Messages | Collapse All Messages