Issue 5656071: code review 5656071: debug/gosym: Remove Makefile, rewrite test using go tool.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5656071: code review 5656071: debug/gosym: Remove Makefile, rewrite test using go tool. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by dsymonds

Modified:
13 years, 3 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

debug/gosym: Remove Makefile, rewrite test using go tool. Update issue 2573.

Patch Set 1 #

Patch Set 2 : diff -r df612f0d549f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r df612f0d549f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r df612f0d549f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r df612f0d549f https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -84 lines)			Patch
R	src/pkg/debug/gosym/Makefile	View	1	1 chunk	+0 lines, -19 lines	0 comments	Download
A	src/pkg/debug/gosym/pclinetest.asm	View	1	1 chunk	+58 lines, -0 lines	0 comments	Download
R	src/pkg/debug/gosym/pclinetest.s	View	1	1 chunk	+0 lines, -60 lines	0 comments	Download
M	src/pkg/debug/gosym/pclntab_test.go	View	1 2 3	3 chunks	+25 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2012-02-16 03:43:53 UTC) #1

dsymonds

Hello r, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 3 months ago (2012-02-16 03:45:16 UTC) #2

dsymonds

13 years, 3 months ago (2012-02-16 03:47:23 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=dcf1093089a7 ***

debug/gosym: Remove Makefile, rewrite test using go tool.

Update issue 2573.

R=r
CC=golang-dev
http://codereview.appspot.com/5656071

Expand All Messages | Collapse All Messages