Issue 565560043: Issue 5712: Split context_specification syntax constructor

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 565560043: Issue 5712: Split context_specification syntax constructor (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 3 months ago by Dan Eble

Modified:
4 years, 2 months ago

Reviewers:
lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

https://sourceforge.net/p/testlilyissues/issues/5712/ ... into context_create and context_find_or_create. This trades the obscurity of a boolean constant for the clarity of specific names.

Patch Set 1 #

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -9 lines)			Patch
M	lily/include/lily-imports.hh	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lily/lily-imports.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lily/parser.yy	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	scm/ly-syntax-constructors.scm	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages