Issue 5655044: Checking in version 639 release binaries.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5655044: Checking in version 639 release binaries. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by chrisha

Modified:
12 years, 11 months ago

Reviewers:
Roger McFarlane, Siggi

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Checking in version 639 release binaries. BUG= TEST= TBR=siggi,rogerm Committed: https://code.google.com/p/sawbuck/source/browse/#svn/trunk640

Patch Set 1 #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+-12 lines, --12 lines)			Patch
D	syzygy/binaries/Benchmark_Chrome-0.1_r572-py2.6.egg	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	syzygy/binaries/Benchmark_Chrome-0.1_r617-py2.6.egg	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/ETW-0.6.5.0-py2.6.egg	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/ETW_Db-0.1_r559-py2.6.egg	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/benchmark.bat	View	1 chunk	+1 line, -1 line	0 comments	Download
M	syzygy/binaries/exe/call_trace.dll	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/call_trace_client.dll	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/call_trace_control.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/call_trace_service.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/instrument.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	syzygy/binaries/exe/profile_client.dll	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/relink.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/reorder.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/run_in_snapshot.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/run_in_snapshot_x64.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/run_in_snapshot_xp.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/exe/wsdump.exe	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	syzygy/binaries/instrument.bat	View	1 chunk	+1 line, -1 line	0 comments	Download
M	syzygy/binaries/optimize.bat	View	1 chunk	+1 line, -1 line	0 comments	Download
M	syzygy/binaries/profile.bat	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Roger McFarlane

lgtm On Thu, Feb 9, 2012 at 2:00 PM, <chrisha@chromium.org> wrote: > Committing this, TBR. ...

12 years, 11 months ago (2012-02-09 19:02:01 UTC) #3

lgtm

Expand All Messages | Collapse All Messages