Issue 5654073: Require ibus-1.4 or later and use ibus_config_get_values.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5654073: Require ibus-1.4 or later and use ibus_config_get_values. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by Daiki Ueno

Modified:
12 years, 2 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

More Reviews

Description

Require ibus-1.4 or later and use ibus_config_get_values. BUG=none TEST=manually

Patch Set 1 #

Patch Set 2 : minor code cleanup: create an empty dict if ibus_config_get_values returns NULL #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -263 lines)			Patch
M	configure.ac	View		2 chunks	+1 line, -10 lines	0 comments	Download
M	src/engine.c	View		4 chunks	+54 lines, -55 lines	0 comments	Download
M	src/m17nutil.h	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/m17nutil.c	View		1 chunk	+0 lines, -98 lines	0 comments	Download
M	src/setup.c	View	1	4 chunks	+95 lines, -84 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Daiki Ueno

Maybe it's good time to drop ibus-1.3 support and use 1.4 API. If ok, I'll ...

12 years, 2 months ago (2012-02-13 08:17:10 UTC) #1

Peng

12 years, 2 months ago (2012-02-13 17:20:23 UTC) #2

On 2012/02/13 08:17:10, Daiki Ueno wrote:
> Maybe it's good time to drop ibus-1.3 support and use 1.4 API.  If ok, I'll
> create 1.3.y branch and push this to master.

lgtm.

Expand All Messages | Collapse All Messages