Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1232)

Issue 564990043: Improve content of tree.gittxt

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 1 week ago by knupero
Modified:
6 months, 3 weeks ago
Reviewers:
wl, carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Improve content of tree.gittxt

Patch Set 1 #

Patch Set 2 : 2nd patchset - improve tree.gittxt #

Patch Set 3 : Version 2 of patch, don't assume there is a local master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M make/lysdoc-targets.make View 1 2 1 chunk +16 lines, -4 lines 0 comments Download

Messages

Total messages: 11
knupero
Hi everybody! With the proposed patch tree.gittxt will contain the name of the current branch ...
7 months, 1 week ago (2019-07-12 21:36:36 UTC) #1
Carl
Why do we want 10 commits instead of just 1? I don't see the rationale ...
7 months, 1 week ago (2019-07-12 22:36:29 UTC) #2
knupero
On 2019/07/12 22:36:29, Carl wrote: > Why do we want 10 commits instead of just ...
7 months, 1 week ago (2019-07-13 07:56:47 UTC) #3
wl_gnu.org
> Well, the patch first adds the name of the branch used This is quite ...
7 months, 1 week ago (2019-07-13 08:52:17 UTC) #4
knupero
> What I would like to see for such branches is the ID of the ...
7 months, 1 week ago (2019-07-14 08:34:26 UTC) #5
wl_gnu.org
>> What I would like to see for such branches is the ID of the ...
7 months, 1 week ago (2019-07-14 08:58:04 UTC) #6
knupero
2nd patchset - improve tree.gittxt
7 months, 1 week ago (2019-07-15 20:45:32 UTC) #7
knupero
We display BRANCH and HEAD. If we find a merge-point with master, we display that ...
7 months, 1 week ago (2019-07-15 21:11:39 UTC) #8
Carl
LGTM. THanks for doing this! Carl
7 months, 1 week ago (2019-07-16 20:59:37 UTC) #9
knupero
Version 2 of patch, don't assume there is a local master
6 months, 3 weeks ago (2019-07-31 06:30:40 UTC) #10
knupero
6 months, 3 weeks ago (2019-07-31 06:40:02 UTC) #11
Patchset 2 was reviewed, counted down, pushed to staging, made it to master.
Then David's patchy broke because I incorrectly assumed that every clone of a
lilypond repository has a local copy of the master branch. Consequently the
patch was reverted in staging and master.

The fix is obvious, we must use 'origin/master' instead of 'master'.

Please review and countdown again.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b