Fix gir annotations.

Fix gir annotations.

- It seems python does not allow to use 'exec' as a variable.
Renamed 'exec' property so that the constructor in IBus.Component is used.
- It seems the python virtual method is available when the function is
described in header files in case that annotations are needed so
the signal function ibus_factory_create_engine is added newly.

TEST=Linux desktop

[fujiwara, 2012-02-13 11:28:44]

I started to port ibus-anthy to python gtk3.
This patch is needed for it.

[Peng, 2012-02-15 02:50:05]

https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c
File src/ibuscomponent.c (right):

https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c#newcode37
src/ibuscomponent.c:37: PROP_EXEC_LINE,
maybe rename it ro cmdline?

https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h
File src/ibusfactory-private.h (right):

https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h#newco...
src/ibusfactory-private.h:28: * This header file is needed to generate the
virtual function of
I think it is better to do more research why scanner does not create
introspection for it.

BTW, you you use create-engine signal instead of override the virtual function?

[fujiwara, 2012-02-15 02:57:41]

On 2012/02/15 02:50:05, Peng wrote:
> https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c
> File src/ibuscomponent.c (right):
> 
> https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c#newcode37
> src/ibuscomponent.c:37: PROP_EXEC_LINE,
> maybe rename it ro cmdline?

OK, you prefer 'cmdline' to 'command_line'.

> 
> https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h
> File src/ibusfactory-private.h (right):
> 
>
https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h#newco...
> src/ibusfactory-private.h:28: * This header file is needed to generate the
> virtual function of
> I think it is better to do more research why scanner does not create
> introspection for it.

Because create_engine needs the annotation. You could see the virtual function
is not available if the annotation is removed.
This is the special way to set annotation for the virtual functions since the
class method is referred as '@create_engine'.

> 
> BTW, you you use create-engine signal instead of override the virtual
function?

Yes, I could. But probably I think python and inherited class are better.

[Peng, 2012-02-15 17:23:47]

On 2012/02/15 02:57:41, fujiwara wrote:
> On 2012/02/15 02:50:05, Peng wrote:
> > https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c
> > File src/ibuscomponent.c (right):
> > 
> > https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c#newcode37
> > src/ibuscomponent.c:37: PROP_EXEC_LINE,
> > maybe rename it ro cmdline?
> 
> OK, you prefer 'cmdline' to 'command_line'.
command_line is better.

> 
> > 
> > https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h
> > File src/ibusfactory-private.h (right):
> > 
> >
>
https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h#newco...
> > src/ibusfactory-private.h:28: * This header file is needed to generate the
> > virtual function of
> > I think it is better to do more research why scanner does not create
> > introspection for it.
> 
> Because create_engine needs the annotation. You could see the virtual function
> is not available if the annotation is removed.
> This is the special way to set annotation for the virtual functions since the
> class method is referred as '@create_engine'.

I tried adding a another function in IBusFactory. It is OK. only create_engine
has the problem. Seems it is related with the return value type of thie
vfunction. I think adding a new header file is not a right way to fix it. We
need do more research for it.

> 
> > 
> > BTW, you you use create-engine signal instead of override the virtual
> function?
> 
> Yes, I could. But probably I think python and inherited class are better.

[Peng, 2012-02-15 17:33:22]

https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c
File src/ibuscomponent.c (right):

https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c#newcode37
src/ibuscomponent.c:37: PROP_EXEC_LINE,
On 2012/02/15 02:50:05, Peng wrote:
> maybe rename it ro cmdline?

Please use COMMAND_LINE

https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c#newcode197
src/ibuscomponent.c:197: g_param_spec_string ("exec_line",
I prefer "command-line" instead of "command_line".

https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h
File src/ibusfactory-private.h (right):

https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h#newco...
src/ibusfactory-private.h:48: ibus_factory_create_engine    (IBusFactory   
*factory,
I checked some doc. Seems there is not a good way to annotate a virtual method. 
But if the virtual method has emitter, maybe it will uses the emitter's
annotation.
So this header file works.

Could you please move this function to ibusfactory.h and make it as a emitter
function?

for example:

IBusEngine *ibus_factory_create_engine(...) {
    g_signal_emit("create-engine", ...,&retval);
    return retval;
}

Future tasks:
I think it is better to add all emitter functions for all signals.

[fujiwara, 2012-02-16 02:24:26]

On 2012/02/15 17:33:22, Peng wrote:
> https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c
> File src/ibuscomponent.c (right):
> 
> https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c#newcode37
> src/ibuscomponent.c:37: PROP_EXEC_LINE,
> On 2012/02/15 02:50:05, Peng wrote:
> > maybe rename it ro cmdline?
> 
> Please use COMMAND_LINE

Done.

> 
> https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c#newcode197
> src/ibuscomponent.c:197: g_param_spec_string ("exec_line",
> I prefer "command-line" instead of "command_line".
> 
> https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h
> File src/ibusfactory-private.h (right):
> 
>
https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h#newco...
> src/ibusfactory-private.h:48: ibus_factory_create_engine    (IBusFactory   
> *factory,
> I checked some doc. Seems there is not a good way to annotate a virtual
method. 
> But if the virtual method has emitter, maybe it will uses the emitter's
> annotation.
> So this header file works.
> 
> Could you please move this function to ibusfactory.h and make it as a emitter
> function?

Great. I thought the real class method would be needed but probably you're
right. The emitter is needed for the virtual functions instead.
I added the ibus_factory_create_engine.

BTW, I'd like to back-port this patch to ibus 1.4 too.
I guess you might like to add '--warn-all' into IBUS_GIR_SCANNERFLAGS in
src/Makefile.am in case of debugging.

> 
> for example:
> 
> IBusEngine *ibus_factory_create_engine(...) {
>     g_signal_emit("create-engine", ...,&retval);
>     return retval;
> }
> 
> Future tasks:
> I think it is better to add all emitter functions for all signals.

[Peng, 2012-02-16 03:21:55]

On 2012/02/16 02:24:26, fujiwara wrote:
> On 2012/02/15 17:33:22, Peng wrote:
> > https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c
> > File src/ibuscomponent.c (right):
> > 
> > https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c#newcode37
> > src/ibuscomponent.c:37: PROP_EXEC_LINE,
> > On 2012/02/15 02:50:05, Peng wrote:
> > > maybe rename it ro cmdline?
> > 
> > Please use COMMAND_LINE
> 
> Done.
> 
> > 
> > https://codereview.appspot.com/5649082/diff/1/src/ibuscomponent.c#newcode197
> > src/ibuscomponent.c:197: g_param_spec_string ("exec_line",
> > I prefer "command-line" instead of "command_line".
> > 
> > https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h
> > File src/ibusfactory-private.h (right):
> > 
> >
>
https://codereview.appspot.com/5649082/diff/1/src/ibusfactory-private.h#newco...
> > src/ibusfactory-private.h:48: ibus_factory_create_engine    (IBusFactory   
> > *factory,
> > I checked some doc. Seems there is not a good way to annotate a virtual
> method. 
> > But if the virtual method has emitter, maybe it will uses the emitter's
> > annotation.
> > So this header file works.
> > 
> > Could you please move this function to ibusfactory.h and make it as a
emitter
> > function?
> 
> Great. I thought the real class method would be needed but probably you're
> right. The emitter is needed for the virtual functions instead.
> I added the ibus_factory_create_engine.
> 
> BTW, I'd like to back-port this patch to ibus 1.4 too.
> I guess you might like to add '--warn-all' into IBUS_GIR_SCANNERFLAGS in
> src/Makefile.am in case of debugging.
> 
> > 
> > for example:
> > 
> > IBusEngine *ibus_factory_create_engine(...) {
> >     g_signal_emit("create-engine", ...,&retval);
> >     return retval;
> > }
> > 
> > Future tasks:
> > I think it is better to add all emitter functions for all signals.

lgtm