Issue 5636052: CPP: Update lite_metadata.cc.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5636052: CPP: Update lite_metadata.cc. (Closed)

Can't Edit
Can't Publish+Mail

Created:
12 years, 2 months ago by philippe

Modified:
12 years, 2 months ago

Reviewers:
Shaopeng, shaopengjia

CC:
leandrogracia, lararennie

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

CPP: Update lite_metadata.cc. This file was not up-to-date which made some unit tests fail in Chrome. Note that the file is not displayed on rietveld since it is too large. Committed: https://code.google.com/p/libphonenumber/source/detail?r=425

Patch Set 1 #

Created: 12 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -0 lines)			Patch

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Shaopeng

12 years, 2 months ago (2012-02-07 06:42:02 UTC) #2

LGTM.

Maybe next time during the code review of upgrading the C++ libphonenumber to a
newer version, we can list all the files that have been changed but not listed
in rietveld because they are too large. That way we can at least notice if some
files are forgotten.

Cheers,

Shaopeng

Expand All Messages | Collapse All Messages