Issue 56360043: go/printer: stricter formatting in struct declarations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 56360043: go/printer: stricter formatting in struct declarations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 3 months ago by cookieo9

Modified:
10 years, 2 months ago

Reviewers:

Visibility:
Public.

Description

go/printer: stricter formatting in struct declarations If a sequence of fields don't all have the same kinds of elements (eg: Names, Types, Tags, Comments), then go fmt (and other uses of go/printer) can align different elements in different lines in the same column. This change fixes the issue by forcing each element type into it's own column unconditionally. Fixes issue 7199. NOTES: This CL currently exists as a proof of concept for the new format. Before this code can be merged, the tests need to be updated, or the code needs to be altered, as two existing tests in go/printer currently fail. Also gri is considering to fix the issue himself, so mail/review is pending.

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
		~rietveld~placeholder~	View	2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Message was sent while issue was closed.

*** Abandoned ***

Expand All Messages | Collapse All Messages